fix:check docker daemon running?#2286
Open
jokestax wants to merge 1 commit into
Open
Conversation
patrickdappollonio
suggested changes
Sep 17, 2024
| err = docker.Checkstatus() | ||
| if err != nil { | ||
| log.Info().Msgf("%s", err) | ||
| return err |
Contributor
There was a problem hiding this comment.
Wrap the error my friend 😆
| err = docker.Checkstatus() | ||
| if err != nil { | ||
| log.Info().Msgf("%s", err) | ||
| return err |
| err = docker.Checkstatus() | ||
| if err != nil { | ||
| log.Info().Msgf("%s", err) | ||
| return err |
| err = docker.Checkstatus() | ||
| if err != nil { | ||
| log.Info().Msgf("%s", err) | ||
| return err |
| err = docker.Checkstatus() | ||
| if err != nil { | ||
| log.Info().Msgf("%s", err) | ||
| return err |
| err = docker.Checkstatus() | ||
| if err != nil { | ||
| log.Info().Msgf("%s", err) | ||
| return err |
| err = docker.Checkstatus() | ||
| if err != nil { | ||
| log.Info().Msgf("%s", err) | ||
| return err |
| err = docker.Checkstatus() | ||
| if err != nil { | ||
| log.Info().Msgf("%s", err) | ||
| return err |
|
|
||
| _, err = cli.Ping(context.Background()) | ||
| if err != nil { | ||
| return fmt.Errorf("Docker is not accessible: %v", err) |
Contributor
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("Docker is not accessible: %v", err) | |
| return fmt.Errorf("Docker is not accessible: %w", err) |
Contributor
|
At the risk of also threading too specifically, are you looking exactly for docker or any container tool? Cc @johndietz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a function to check if docker is installed and if installed running or not
How to test
Build the binary and run "./kubefirst k3d create" or any cloud provider