Implementing support for Achievements in RetroPlayer - #73
Closed
Shardul555 wants to merge 2 commits into
Closed
Shardul555 wants to merge 2 commits into
Shardul555 wants to merge 2 commits into
Conversation
13 tasks
13 tasks
|
Any updates/news on #73 and garbear/xbmc#126 or garbear/xbmc#127 now that #67 has been merged? |
Contributor
|
@NikosSiak is upstreaming his GSoC 2020 work. We'll return to GSoC 2021 after. |
7 tasks
Contributor
|
@Shardul555 It's time! Can you cherry-pick 1ed068e and open a new PR against the |
Contributor
Author
|
Hi Garbear,
I have opened a PR: #104
Please review it whenever possible.
Thanks and Regards,
Shardul Semwal
…On Wed, Feb 1, 2023 at 4:03 AM Garrett Brown ***@***.***> wrote:
@Shardul555 <https://github.com/Shardul555> It's time! Can you
cherry-pick 1ed068e
<1ed068e>
and open a new PR against the Omega branch?
—
Reply to this email directly, view it on GitHub
<#73 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANSVQFOPRHGPYASTC7P5FTDWVGHLTANCNFSM5CQYHLIQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
|
Superseded by #104 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implement support for Achievements in ReteroPlayer. This PR is based on #67 , for adding support of RCheevos.
This PR is used by garbear-xbmc #126 for implementing Achievements.