Skip to content

Fix dig2doggo to preserve long flags and always add --time #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kluzzebass merged 1 commit into from
Jan 23, 2026
Merged

Fix dig2doggo to preserve long flags and always add --time #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions translator/dig2doggo/translator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ func translateFlags(args []string) []string {

if strings.HasPrefix(arg, "-") && len(arg) > 1 {
if arg[1] == '-' {
result = append(result, arg)
continue
}

Expand Down Expand Up @@ -155,6 +156,8 @@ func translateFlags(args []string) []string {
}
}

result = append(result, "--time")

if queryName != "" {
result = append(result, "-q", queryName)
}
Expand Down
68 changes: 34 additions & 34 deletions translator/dig2doggo/translator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,172 +14,172 @@ func TestTranslate(t *testing.T) {
{
name: "simple query",
args: []string{"example.com"},
want: []string{"-q", "example.com"},
want: []string{"--time", "-q", "example.com"},
},
{
name: "query with type",
args: []string{"example.com", "MX"},
want: []string{"-q", "example.com", "-t", "MX"},
want: []string{"--time", "-q", "example.com", "-t", "MX"},
},
{
name: "query with nameserver",
args: []string{"@8.8.8.8", "example.com"},
want: []string{"-q", "example.com", "-n", "8.8.8.8"},
want: []string{"--time", "-q", "example.com", "-n", "8.8.8.8"},
},
{
name: "query with type and nameserver",
args: []string{"@8.8.8.8", "example.com", "A"},
want: []string{"-q", "example.com", "-t", "A", "-n", "8.8.8.8"},
want: []string{"--time", "-q", "example.com", "-t", "A", "-n", "8.8.8.8"},
},
{
name: "short flag -q",
args: []string{"-q", "example.com"},
want: []string{"-q", "example.com"},
want: []string{"--time", "-q", "example.com"},
},
{
name: "short flag -t",
args: []string{"-t", "AAAA", "example.com"},
want: []string{"-q", "example.com", "-t", "AAAA"},
want: []string{"--time", "-q", "example.com", "-t", "AAAA"},
},
{
name: "short flag -t combined",
args: []string{"-tAAAA", "example.com"},
want: []string{"-q", "example.com", "-t", "AAAA"},
want: []string{"--time", "-q", "example.com", "-t", "AAAA"},
},
{
name: "ipv4 only",
args: []string{"-4", "example.com"},
want: []string{"-4", "-q", "example.com"},
want: []string{"-4", "--time", "-q", "example.com"},
},
{
name: "ipv6 only",
args: []string{"-6", "example.com"},
want: []string{"-6", "-q", "example.com"},
want: []string{"-6", "--time", "-q", "example.com"},
},
{
name: "reverse lookup",
args: []string{"-x", "8.8.8.8"},
want: []string{"-x", "-q", "8.8.8.8"},
want: []string{"-x", "--time", "-q", "8.8.8.8"},
},
{
name: "plus short option",
args: []string{"+short", "example.com"},
want: []string{"--short", "-q", "example.com"},
want: []string{"--short", "--time", "-q", "example.com"},
},
{
name: "plus tcp option",
args: []string{"+tcp", "example.com"},
want: []string{"-n", "@tcp://", "-q", "example.com"},
want: []string{"-n", "@tcp://", "--time", "-q", "example.com"},
},
{
name: "plus dnssec option",
args: []string{"+dnssec", "example.com"},
want: []string{"--do", "-q", "example.com"},
want: []string{"--do", "--time", "-q", "example.com"},
},
{
name: "plus recurse option",
args: []string{"+recurse", "example.com"},
want: []string{"--rd", "-q", "example.com"},
want: []string{"--rd", "--time", "-q", "example.com"},
},
{
name: "plus aa option",
args: []string{"+aa", "example.com"},
want: []string{"--aa", "-q", "example.com"},
want: []string{"--aa", "--time", "-q", "example.com"},
},
{
name: "plus ad option",
args: []string{"+ad", "example.com"},
want: []string{"--ad", "-q", "example.com"},
want: []string{"--ad", "--time", "-q", "example.com"},
},
{
name: "plus cd option",
args: []string{"+cd", "example.com"},
want: []string{"--cd", "-q", "example.com"},
want: []string{"--cd", "--time", "-q", "example.com"},
},
{
name: "plus nsid option",
args: []string{"+nsid", "example.com"},
want: []string{"--nsid", "-q", "example.com"},
want: []string{"--nsid", "--time", "-q", "example.com"},
},
{
name: "plus cookie option",
args: []string{"+cookie", "example.com"},
want: []string{"--cookie", "-q", "example.com"},
want: []string{"--cookie", "--time", "-q", "example.com"},
},
{
name: "plus padding option",
args: []string{"+padding", "example.com"},
want: []string{"--padding", "-q", "example.com"},
want: []string{"--padding", "--time", "-q", "example.com"},
},
{
name: "plus ede option",
args: []string{"+ede", "example.com"},
want: []string{"--ede", "-q", "example.com"},
want: []string{"--ede", "--time", "-q", "example.com"},
},
{
name: "plus search option",
args: []string{"+search", "example.com"},
want: []string{"--search", "-q", "example.com"},
want: []string{"--search", "--time", "-q", "example.com"},
},
{
name: "plus timeout option",
args: []string{"+timeout=5", "example.com"},
want: []string{"--timeout", "5s", "-q", "example.com"},
want: []string{"--timeout", "5s", "--time", "-q", "example.com"},
},
{
name: "plus ndots option",
args: []string{"+ndots=2", "example.com"},
want: []string{"--ndots", "2", "-q", "example.com"},
want: []string{"--ndots", "2", "--time", "-q", "example.com"},
},
{
name: "plus subnet option",
args: []string{"+subnet=192.0.2.0/24", "example.com"},
want: []string{"--ecs", "192.0.2.0/24", "-q", "example.com"},
want: []string{"--ecs", "192.0.2.0/24", "--time", "-q", "example.com"},
},
{
name: "query with class",
args: []string{"example.com", "IN", "A"},
want: []string{"-q", "example.com", "-t", "A", "-c", "IN"},
want: []string{"--time", "-q", "example.com", "-t", "A", "-c", "IN"},
},
{
name: "query with class flag",
args: []string{"-c", "CH", "example.com"},
want: []string{"-q", "example.com", "-c", "CH"},
want: []string{"--time", "-q", "example.com", "-c", "CH"},
},
{
name: "complex query",
args: []string{"-4", "+short", "+dnssec", "@1.1.1.1", "example.com", "MX"},
want: []string{"-4", "--short", "--do", "-q", "example.com", "-t", "MX", "-n", "1.1.1.1"},
want: []string{"-4", "--short", "--do", "--time", "-q", "example.com", "-t", "MX", "-n", "1.1.1.1"},
},
{
name: "nameserver with protocol",
args: []string{"@tcp://8.8.8.8", "example.com"},
want: []string{"-q", "example.com", "-n", "@tcp://8.8.8.8"},
want: []string{"--time", "-q", "example.com", "-n", "@tcp://8.8.8.8"},
},
{
name: "nameserver with https",
args: []string{"@https://cloudflare-dns.com/dns-query", "example.com"},
want: []string{"-q", "example.com", "-n", "@https://cloudflare-dns.com/dns-query"},
want: []string{"--time", "-q", "example.com", "-n", "@https://cloudflare-dns.com/dns-query"},
},
{
name: "debug mode",
args: []string{"-m", "example.com"},
want: []string{"--debug", "-q", "example.com"},
want: []string{"--debug", "--time", "-q", "example.com"},
},
{
name: "multiple plus options",
args: []string{"+short", "+dnssec", "+nsid", "example.com"},
want: []string{"--short", "--do", "--nsid", "-q", "example.com"},
want: []string{"--short", "--do", "--nsid", "--time", "-q", "example.com"},
},
{
name: "negated plus option",
args: []string{"+norecurse", "example.com"},
want: []string{"-q", "example.com"},
want: []string{"--time", "-q", "example.com"},
},
{
name: "combined short flags",
args: []string{"-4m", "example.com"},
want: []string{"-4", "--debug", "-q", "example.com"},
want: []string{"-4", "--debug", "--time", "-q", "example.com"},
},
}

Expand Down
Loading