Make dialog collapsed and maximized states mutually exclusive#1690
Merged
klembot merged 3 commits intoJul 13, 2026
Merged
Conversation
klembot
requested changes
Jul 5, 2026
f2c93a9 to
d3ced22
Compare
klembot
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enforces the dialog state invariant discussed in #1418: a dialog should not be both collapsed and maximized at the same time.
The reducer now clears
maximizedwhen a dialog is collapsed, and clearscollapsedwhen a dialog is maximized. This prevents the remaining blank fullscreen dialog state caused by a maximized wrapper around a collapsed dialog (open the stylesheet/JavaScript pane, maximize it, then collapse it).Adds reducer coverage for both state transitions.
Notes for reviewer
Two things noted but intentionally not changed here — this PR sells one thing: the
!(collapsed && maximized)invariant.passage-edit-stack.tsx'scollapsed && maximizedstyle branch becomes dead code once that state can't occur. Left as-is; normal collapsed styling is unaffected.setDialogMaximizedalready clearsmaximizedon all dialogs for an out-of-range index (the existing incorrect-index test doesn't exercise this). Pre-existing; untouched.Issues Fixed
Addresses the remaining dialog state issue discussed in #1418.
Using "Addresses" rather than "Fixes" pending a manual UI pass on the stylesheet/JavaScript panel, a single passage editor, and a passage stack with several passages.
Credit
Please put an X in one of the squares below only.
Presubmission Checklist
Put an X in the squares below to indicate you've done each step.