Skip to content

feat: passport NFC scan#11

Merged
Eikix merged 8 commits into
mainfrom
feat/passport-scan
Jun 3, 2025
Merged

feat: passport NFC scan#11
Eikix merged 8 commits into
mainfrom
feat/passport-scan

Conversation

@zmalatrax

Copy link
Copy Markdown
Contributor

Resolves CORE-723
Resolves CORE-715

feat: add manual mrz key and display nfc info
Comment thread app/_layout.tsx Outdated
Comment thread modules/mrz-reader/ios/MrzReaderView.swift Outdated
Comment thread modules/nfc-reader/ios/NfcReaderModule.swift Outdated
Comment thread modules/nfc-reader/ios/NfcReaderModule.swift Outdated
Comment thread modules/nfc-reader/ios/NfcReaderModule.swift Outdated
Comment thread modules/nfc-reader/src/NfcReader.types.ts Outdated
@Eikix

Eikix commented Jun 3, 2025

Copy link
Copy Markdown
Member

Great addition in general -> cleaner flow
Awaiting the smol fixes from comments and good to merge

Comment thread modules/mrz-reader/ios/MrzReaderView.swift

@Eikix Eikix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eikix Eikix merged commit 29c11a6 into main Jun 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants