You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request implements replacing the ###--- progress bar with the -C o o style, based on /etc/pacman.conf. Since pakku wraps pacman in places, this will make both outputs look the same.
It also includes two commits I made to get Nim building that are probably poorly and unsafely done, and can be trashed if need be.
Could you make a PR for the Easter Egg patch here for pakku-git: https://github.com/zqqw/pakku
Although I could add it myself, it would make it easier to keep the history right with you as the author then. I don't think I can easily merge it as it is due to some minor changes in related areas. Sorry I didn't spot this sooner, fantastic idea!
There are no warnings building pakku-git. Benjamin Shirley-Quirk's patch has fixed it and it builds with the current nim-git.
I had to manually merge it in some places, here is the diff I ended up with if it makes it a bit easier, hope it's OK, apparently working anyway:
Sure thing, let me know if the pull request I just opened works. I'm going to leave this one open too, just in case kitsunyan checks back in and decides to merge some stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements replacing the
###---progress bar with the-C o ostyle, based on/etc/pacman.conf. Since pakku wraps pacman in places, this will make both outputs look the same.It also includes two commits I made to get Nim building that are probably poorly and unsafely done, and can be trashed if need be.