List Comprehensions => collect -- fixes break since Nim 1.2#58
Open
shirleyquirk wants to merge 15 commits into
Open
List Comprehensions => collect -- fixes break since Nim 1.2#58shirleyquirk wants to merge 15 commits into
shirleyquirk wants to merge 15 commits into
Conversation
…eOffset: empty description field)
Support remote passwd providers like SSSD.
Author
|
I did a neater but more aggressive version of this commit into pakku-git, basically this but without the I'm not sure how to pr to the aur, I'll look into that too if that makes it easier |
shirleyquirk
changed the title
|
I'm also facing this issue when I tried to install pakku on a new Arch box today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on zqqw's work, refactored lc's to use the new
collectmacroalso removed other deprecation warnings (size_t, []=, dirExists, Exceptions)
Currently all the lc's are still in the code, wrapped in
when NimVersionstatements which is super messy but makes it easy to search through for all the changesthere are still a couple list comprehensions that don't work on 1.2.6, but are in latest devel, so that's also wrapped in a NimVersion block.