Merged
Conversation
- There are TinderAnswers for each community, and they're accessible and editable from the CommunitiesController - Other minor changes
Isti01
force-pushed
the
staging
branch
2 times, most recently
from
6b0ae11 to
2609f29
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Isti01
reviewed
Feb 3, 2026
backend/src/main/kotlin/hu/bme/sch/cmsch/component/communities/TinderService.kt
Outdated
Show resolved
Hide resolved
Isti01
reviewed
Feb 3, 2026
backend/src/main/kotlin/hu/bme/sch/cmsch/component/communities/TinderService.kt
Outdated
Show resolved
Hide resolved
Isti01
reviewed
Feb 3, 2026
backend/src/main/kotlin/hu/bme/sch/cmsch/component/communities/CommunitiesController.kt
Show resolved
Hide resolved
Isti01
reviewed
Feb 3, 2026
| return "admin403" | ||
| } | ||
|
|
||
| val questions = transactionManager.transaction(readOnly = true) { tinderService.getAllQuestions() } |
Collaborator
There was a problem hiding this comment.
Opening a lot of short transactions, maybe mark the public methods as @Transactional instead?
Isti01
requested changes
Feb 3, 2026
Collaborator
Isti01
left a comment
Isti01
left a comment
There was a problem hiding this comment.
I might be missing something, but I think the endpoints for the tinder interaction are missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New functionality: tinder!
The organizers can give single choice questions with the answer options, and they can answer these questions with communities from /admin/control/community. No answers are required.
There is also an API endpoint for submitting answers to the tinder questions by users as well, and an endpoint for retrieving the communities ordered by the number of matching answers with the user.