feat(config) add ENV_DIR for safe local env storage #902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #861
I add new config - ENV_DIR
This dir is abs path to safe folder in doco cd filesystem (not inside repos). In this folder users can store their .env files.
To add this files to apps deployment I extend env_files option: it's new prefix "file:<relative_path>", this path relative to ENV_DIR and can't load files outside for security issues.
My motivation was to add some envs that change outside of my IaC commits (some secrets that i generate by api), so I can't keep it in code as encrypted data. But i don't want up external secrets manager because its overkill for this type of problem.
Also ArgoCD have inline variables like in #861 but i prefer to extend remote: syntax