Open
Conversation
Collaborator
IMozgg
commented
May 27, 2019
IMozgg
commented
- modify PointOfInterest. add RestController, modify annotation
- modify Category, add RestController, modify annotation
- add Integration tests for POI and Category
- remove all Address of DAO, Service, and Controllel
…vice + Controller)
…onTest class. 2) CustomerRequestStageName#name annotated with @notblank. 3) Modified RestRequest: added automated REST resource detection by entity class (added restPathsMap); typeReferencesMap added, to automate detection of necessary ParameterizedTypeReference by class. 4) Modified MockFactory: added automated mock supplier detection by entity class (added mockSuppliersMap).
…upport Customer entity
…onExistentCustomer and modified CustomerController#getCustomerById method (status codes added), 2) CustomerController annotated with @RestController instead of @controller, 3) Corresponding request mappings set to controller methods (@GetMapping, @PostMapping etc)
…eleteCustomer 2) CustomerController#addCustomer and CustomerController#deleteCustomer modified in order to return response codes 3) Fixed random birth date creation in MockFactory#getMockCustomer
…t#getDeletedCustomer
…raints for login, email and password fields
…trollerIntegrationTest#checkNotBlankConstraintForName_whenCustomerRequestStageUpdate, added some comments
…llCustomers, added ParametrizedTypeReference<List<Customer>> into RestRequests#typeReferencesMap
…t#getResponseEntityFromPostRequest
…t#getCustomerById
…thods for constraint checks during updating an entity. 2) Added overloaded version for RestRequests#updateEntityWithIncorrectField method.
…erControllerIntegrationTest.
…ted into the RestRequests and MockFactory/ 2) An Operator entity migrated to Lombok (including embeddable) 3) OperatorController modified as RestController (including status codes) 4) MockFactory#getMockCustomerRequestStage fixed - changed status code to CREATED fot list of Operator entities
…essassistant into feature/ba-0107
- add ResponseStatus to method
- remove Addres of DAO, Service and Controller;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.