This repository was archived by the owner on Oct 29, 2021. It is now read-only.
Adjust method signatures to match parent#36
Open
splitbrain wants to merge 1 commit intokettari:masterfrom
splitbrain-forks:php7-signature
Open
Adjust method signatures to match parent#36splitbrain wants to merge 1 commit intokettari:masterfrom splitbrain-forks:php7-signature
splitbrain wants to merge 1 commit intokettari:masterfrom
splitbrain-forks:php7-signature
Conversation
|
This was already addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with PHP 7, classes that overide methods from their parent have to match their parent's method signature regarding type hints. Otherwise PHP will throw an error.
Your plugin seems not to match DokuWiki's method signatures causing it to fail under PHP7. This patch tries to fix that.
Please note that this patch and the resulting pull request were created using an automated tool. Something might have gone, wrong so please carefully check before merging.
If you think the code submitted is wrong, please feel free to close this PR and excuse the mess.