-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix(core): add missing rendered labels when creating trigger run context #13948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MTarek165
wants to merge
16
commits into
kestra-io:develop
Choose a base branch
from
MTarek165:fix/labels-render-failure-with-triggers
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(core): add missing rendered labels when creating trigger run context #13948
MTarek165
wants to merge
16
commits into
kestra-io:develop
from
MTarek165:fix/labels-render-failure-with-triggers
+235
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… labels map to list of labels
- inject all labels earlier than ScheduledExecutionFactory which is useful for input rendering using labels - flow labels and system.from label should be added earlier at RunVariables - trigger, backfill and system.correlationId would be postponed a little bit into RunContextInitializer for rendering and triggerExecutionId existence
- resolved labels from run context should be the same attached to execution at ScheduledExecutionFactory
Contributor
Author
|
@loicmathieu I wonder also if we can create new run context of new execution after adding labels and use it for rendering inputs, this is a simpler fix but I feel that it is not clean as there is no way to inject RunContextFactory into ScheduledExecutionFactory without making some undesired changes in evaluate() method |
…dulable trigger only
…ill labels as flow labels
- this is useful for rendering flow labels earlier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/backend
Needs backend code changes
kind/external
Pull requests raised by community contributors
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13807
Problem
Solution
Testing
Notes