[kentcdodds]

Intent

Drop leftover agent-written test asserts that cannot fail on a real regression: the curated_feeds filter_in/filter_out PRAGMA absence, and the leftover data-admin-route-placeholder not.toContain after the hydrated-shell oracle. State-flip absences stay.

Door: two-way

Cleanup: none

Why

Daily keep-tests-tight pass. docs/contributing/testing-principles.md is not in this repo; this applies the same leftover-assert rules: every remaining test needs an independent oracle.

Testing

• npm run check (oxfmt + oxlint)
• npx tsc --noEmit passed
• npm run validate — format, lint, typecheck, and 45 files / 306 tests passed

No app behavior changed, so control CLI request/browse would not prove anything beyond the existing suite.

Pre-existing lint warnings left alone: conditional expect in version.test.ts (already on main) and beforeEach in media-metadata-tools.test.ts.

System recap

Risk: low Touches: test suites only (app/db/feeds.test.ts, app/routes/admin/index.test.ts)

(extends existing coverage; no product code)

Removed leftover asserts in:

• feeds.test.ts — lone not.toContain('filter_in'|'filter_out') after curated feeds never had those columns
• admin/index.test.ts — leftover data-admin-route-placeholder absence; the script-tag oracle still proves the hydrated shell

Kept state-flip absences (token present → revoke → gone, diagnostics present → clear → gone, usedAt null → consume → set), JWKS/refresh_token non-empty checks that are the only oracle, and first-fetch result1 null-check where the next assert is fetch count.

  

---

Note

Low Risk
Only test assertions were removed; no production code paths were modified.

^{Reviewed by Cursor Bugbot for commit 8f9bd63. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 7bd4403c-dd5a-4213-82ca-6d4b65068507

Commits

Reviewing files that changed from the base of the PR and between e072dc2 and 8f9bd63.

Files selected for processing: 2

• app/db/feeds.test.ts
• app/routes/admin/index.test.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}