fix: Add newline after qr code and print usage if incorrect number of args passed#48
Open
ssnover wants to merge 3 commits intokennytm:masterfrom
Open
fix: Add newline after qr code and print usage if incorrect number of args passed#48ssnover wants to merge 3 commits intokennytm:masterfrom
ssnover wants to merge 3 commits intokennytm:masterfrom
Conversation
ssnover
changed the title
Author
|
@kennytm The code coverage analysis seems too sensitive. It seems like there should be a set coverage target (say 90%) and the coverage of a given PR should be compared with the target. Having it fail on any decrease seems like too much. I'm not familiar with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #47 and adds a newline following print out of QR code to stdout.