fix: batch_enrich merges enrichments instead of overwriting#5703
Closed
zorroxlab wants to merge 1 commit intokeephq:mainfrom
Closed
fix: batch_enrich merges enrichments instead of overwriting#5703zorroxlab wants to merge 1 commit intokeephq:mainfrom
zorroxlab wants to merge 1 commit intokeephq:mainfrom
Conversation
Fixes keephq#5692 The batch_enrich function was overwriting existing enrichments instead of merging new fields with existing ones. This caused downstream workflows that depend on previously enriched fields (e.g., ticket_id, ticket_url) to fail. Changes: - Added force parameter to batch_enrich (defaults to False) - When force=False, new enrichments are merged with existing ones: {**existing, **new} - When force=True, existing enrichments are overwritten (original behavior) - Updated existing enrichments individually instead of bulk update to properly merge JSON fields
|
Someone is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
|
Fix Bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
Target branch is not in the allowed branches list. |
Member
|
closing as probably AI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5692 - batch_enrich was overwriting existing enrichments instead of merging
Problem
When using the bulk status change feature in the UI, batch_enrich() replaced all existing alert enrichments instead of merging new fields with existing ones. This caused downstream workflows that depend on previously enriched fields (e.g., ticket_id, ticket_url) to fail.
Solution
Changes
Testing
Fixes #5692