fix(api): rename /alerts/event/error to /alerts/event-errors#5640
Closed
MekonMAC wants to merge 1 commit intokeephq:mainfrom
Closed
fix(api): rename /alerts/event/error to /alerts/event-errors#5640MekonMAC wants to merge 1 commit intokeephq:mainfrom
MekonMAC wants to merge 1 commit intokeephq:mainfrom
Conversation
|
Someone is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
Bot
added
the
size:XS
|
|
Contributor
|
Target branch is not in the allowed branches list. |
MekonMAC
force-pushed
the
fix/5521-oauth2-redirect-loop-rename-error-endpoint-v2
branch
from
edbdf62 to
ed9c806
Compare
Contributor
Author
|
Hi Team! It seems that the CI for this PR is failing due to some global issues in the main branch:
Could you please take a look at these infrastructure/main-branch issues? Once fixed, I'll rebase my PR. Thanks! 🚀 |
Contributor
Author
|
Hi team, just following up on the CI failures for this PR. Are there any updates on the main branch infrastructure issues? Thanks! @MekonMAC |
Member
|
Closing: AI-generated spam. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5521.
This PR renames the GET endpoint
/alerts/event/errorto/alerts/event-errors(and its corresponding dismiss endpoint).Problem:
When using OAuth2-proxy (or similar auth proxies), users often bypass auth for webhook endpoints using a regex like
/alerts/event.*. Because/alerts/event/errorstarts with the same prefix but is a frontend GET request requiring user authentication, it gets caught in the bypass. This leads to the backend receiving requests without user headers, returning 401/403, and triggering a redirect loop in the UI.Solution:
Renaming the endpoint to
/alerts/event-errorsremoves the collision with the webhook ingestion path prefix, allowing auth proxies to correctly distinguish between public webhooks and private API calls.