fix: filter Keep-internal fields from Jira kwargs#5630
fix: filter Keep-internal fields from Jira kwargs#5630zekebawt wants to merge 2 commits intokeephq:mainfrom
Conversation
|
@zekebawt is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
|
Target branch is not in the allowed branches list. |
Fixes regression introduced in keephq#5607 where Keep-internal workflow fields (enrich_alert, enrich_incident, dispose_on_new_alert, audit_enabled, etc.) were being passed to Jira API, causing 'cannot be set' errors. Filtered fields: - enrich_alert, enrich_incident - dispose_on_new_alert - audit_enabled - if, name, condition, foreach, throttle, provider Preserves original keephq#5607 priority filtering logic. Closes regression reported by @Eliesmbr in keephq#5607.
80e6186 to
c2a4f1a
Compare
|
@zekebawt would you mind fix the "test docs" step? |
|
I think also some unit tests are failing because of the new change. Would you mind fixing these @zekebawt ? Currently all new PR pipelines will fail. |
|
The 5 failing tests in The tests use This hits a monkey-patch in The tests should use Unfortunately i can not commit to |
Fixes #5534
Fixes regression introduced in #5607 where Keep-internal workflow fields were being passed to Jira API, causing errors.
Problem
The kwargs block added in #5607 filtered priority values but passed all remaining kwargs to Jira fields. This included Keep-internal fields that Jira rejects with 'cannot be set' errors.
Reported by @Eliesmbr in #5607 comments.
Solution
Added explicit filtering for Keep-internal fields:
These are now skipped while legitimate Jira fields continue to work.
Testing
Regression Fixed
Resolves: 'Field '''enrich_alert''' cannot be set. It is not on the appropriate screen, or unknown.'