Skip to content

Fix null counts exceeding per-file record counts #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keemgdeok wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix null counts exceeding per-file record counts #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/io/github/keemgdeok/metadq/iceberg/EvidenceCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,9 @@ && contains(file.upperBounds(), field.fieldId())) {
if (isNegative(values) || isNegative(nulls) || isNegative(nans)) {
inconsistent = true;
}
if (nulls != null && nulls > file.recordCount()) {
inconsistent = true;
}
if (values != null && nulls != null && nulls > values) {
inconsistent = true;
}
Expand Down
84 changes: 84 additions & 0 deletions src/test/java/io/github/keemgdeok/metadq/iceberg/EvidenceCollectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;

import io.github.keemgdeok.metadq.core.ReasonCode;
import io.github.keemgdeok.metadq.core.RuleEvaluator;
import io.github.keemgdeok.metadq.core.RuleSpec.NullRatioRule;
import io.github.keemgdeok.metadq.core.RuleSpec.RowCountRule;
import io.github.keemgdeok.metadq.core.Status;
import java.time.Clock;
import java.util.Map;
import java.util.Set;
import org.apache.iceberg.DataFiles;
Expand All @@ -14,6 +20,8 @@
import org.apache.iceberg.exceptions.NotFoundException;
import org.apache.iceberg.inmemory.InMemoryFileIO;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.CsvSource;

class EvidenceCollectorTest {
@Test
Expand Down Expand Up @@ -114,6 +122,82 @@ void marksContradictoryCountsAsInconsistent() throws Exception {
}
}

@ParameterizedTest
@CsvSource({"10,20,false", "10,20,true", "0,1,false", "10,10,false", "10,0,false", "0,0,false"})
void checksNullCountsAgainstFileRecordCount(long rows, long nulls, boolean includeValueCount)
throws Exception {
try (DemoTableFactory.DemoTable demo = DemoTableFactory.createEmpty()) {
var file =
DataFiles.builder(demo.table().spec())
.withPath("memory://metadq/content/null-counts.parquet")
.withFormat(FileFormat.PARQUET)
.withFileSizeInBytes(128)
.withMetrics(
new Metrics(
rows,
null,
includeValueCount ? Map.of(2, Math.max(rows, nulls)) : null,
Map.of(2, nulls),
null))
.build();
demo.table().newAppend().appendFile(file).commit();

var evidence =
new EvidenceCollector().collect("demo.events", demo.table(), Set.of("user_id"));
boolean inconsistent = nulls > rows;
assertEquals(inconsistent, evidence.columns().get("user_id").inconsistentMetrics());
assertFalse(evidence.recordCountsInconsistent());
assertEquals(
Status.PASS,
RuleEvaluator.evaluate(new RowCountRule("rows", rows, rows), evidence, Clock.systemUTC())
.status());

var result =
RuleEvaluator.evaluate(
new NullRatioRule("nulls", "user_id", 1), evidence, Clock.systemUTC());
if (inconsistent) {
assertEquals(Status.UNKNOWN, result.status());
assertEquals(ReasonCode.INCONSISTENT_METRICS, result.reasonCode());
} else if (rows == 0) {
assertEquals(Status.UNKNOWN, result.status());
assertEquals(ReasonCode.EMPTY_TABLE, result.reasonCode());
} else {
assertEquals(Status.PASS, result.status());
}
}
}

@Test
void detectsFileNullCountContradictionHiddenByOtherFiles() throws Exception {
try (DemoTableFactory.DemoTable demo = DemoTableFactory.create()) {
var file =
DataFiles.builder(demo.table().spec())
.withPath("memory://metadq/content/invalid-score-nulls.parquet")
.withFormat(FileFormat.PARQUET)
.withFileSizeInBytes(128)
.withMetrics(new Metrics(10L, null, null, Map.of(3, 20L), null))
.build();
demo.table().newAppend().appendFile(file).commit();

var evidence = new EvidenceCollector().collect("demo.events", demo.table());

assertEquals(1_210, evidence.metadataRecordCount());
assertEquals(23, evidence.columns().get("score").nullCount());
assertTrue(evidence.columns().get("score").inconsistentMetrics());
assertFalse(evidence.columns().get("event_id").inconsistentMetrics());
assertEquals(
Status.PASS,
RuleEvaluator.evaluate(
new NullRatioRule("event-nulls", "event_id", 0), evidence, Clock.systemUTC())
.status());
var result =
RuleEvaluator.evaluate(
new NullRatioRule("score-nulls", "score", 1), evidence, Clock.systemUTC());
assertEquals(Status.UNKNOWN, result.status());
assertEquals(ReasonCode.INCONSISTENT_METRICS, result.reasonCode());
}
}

@Test
void marksPositiveNullCountForRequiredColumnAsInconsistent() throws Exception {
try (DemoTableFactory.DemoTable demo = DemoTableFactory.create()) {
Expand Down
Loading