PTV-1904 update release notes, bump version to 1.4.1

[briehl]

As the title says.

[briehl]

PR Review: PTV-1904 update release notes, bump version to 1.4.1

Overview

This PR updates the release notes and bumps the version to 1.4.1 to reflect the bug fixes from the PTV-1904 ticket. It also includes cleanup of unused imports and fixes a function call to use the refactored utility function.

Changes Summary

Files Modified:

• RELEASE_NOTES.md - Adds 1.4.1 release entry
• kbase.yml - Version bump and owner update
• lib/kb_gtdbtk/core/gtdbtk_runner.py - Import cleanup and type hint fix
• lib/kb_gtdbtk/kb_gtdbtkImpl.py - Use refactored utility function

Statistics:

• Additions: 10 lines
• Deletions: 7 lines
• Net change: +3 lines

Detailed Review

Positive Aspects:

1. ✅ Release Notes - Clear and concise:

   • Version 1.4.1 added at top of file
   • Describes the fix: "Fixed report generation and file post-processing issues"
   • Explains what was fixed without excessive detail

2. ✅ Version Bump - Correct semantic versioning:

   • Changed from 1.4.0 to 1.4.1 (patch release for bug fix)
   • Appropriate for addressing bugs rather than new features

3. ✅ Owner Update - Adds maintainer:

   • Added wjriehl (Bill Riehl) to the owners list
   • Makes sense given active maintenance on these tickets

4. ✅ Import Cleanup - Removed unused imports:

   • Removed from dataclasses import dataclass (never used)
   • Removed from datetime import datetime (now in string_util)
   • Good housekeeping following refactoring in PR PTV-1904 refactor timestamp code #95

5. ✅ Type Hint Improvement - Better Python compatibility:

   • Changed from dict[str, list|dict] to Dict[str, Union[List, Dict]]
   • Uses typing module imports (compatible with Python < 3.10)
   • Consistent with project's type hinting approach

6. ✅ Function Call Fix - Uses refactored utility:

   • Changed self.now_ISOish() to now_ISOish() in kb_gtdbtkImpl.py
   • Correctly uses the imported utility function from PR PTV-1904 refactor timestamp code #95
   • Removes the method from the class (already removed in PR PTV-1904 refactor timestamp code #95)

Observations & Questions

1. Release Notes Detail Level - The entry is somewhat vague:

   • "Fixed report generation and file post-processing issues" is accurate but high-level
   • For users: might be helpful to note "Fixes issue with TSV files containing empty fields"
   • Current level is fine for a patch release, but more detail wouldn't hurt

2. Version Numbering - Jumping from 1.4.0 to 1.4.1:

   • Previous note mentions "Reverting to most recent prior release to address the recurring bug from the new release 1.4.0"
   • So 1.4.0 was problematic and reverted to 1.0.1
   • 1.4.1 now fixes the 1.4.0 issues - this makes sense

3. Owner List - Now has 9 owners:

   • Good to have active maintainers listed
   • Consider if this list should be pruned periodically for inactive contributors

Potential Concerns

1. Minor: Import order in gtdbtk_runner.py:

   • Removed from datetime import datetime but kept other imports
   • Import organization looks clean overall
   • No style issues

2. Documentation Completeness - Release notes could include:

   • Link to the PTV-1904 ticket (optional)
   • More specific description of what was fixed (e.g., "Fixes TSV parsing with trailing empty fields")
   • Current description is acceptable though

Verdict

✅ APPROVED - This is a straightforward and correct maintenance release PR. The version bump is appropriate, the release notes are clear, and the code cleanup properly incorporates changes from previous PRs.

Strengths:

• Correct semantic versioning
• Import cleanup and type hint improvements
• Proper use of refactored utilities
• Clear release notes

Optional improvements:

• Could add slightly more detail to release notes about the specific fix
• This is a minor point and current notes are sufficient

The PR is ready to merge. This completes the bug fixes for PTV-1904 and properly documents the release.