Update gha#3733
Open
briehl wants to merge 3 commits into
Open
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3733 +/- ##
===========================================
- Coverage 25.96% 25.82% -0.15%
===========================================
Files 461 461
Lines 46691 46691
===========================================
- Hits 12122 12056 -66
- Misses 34569 34635 +66 see 11 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Member
Author
|
The image now builds and pushes. Tests run but fail because some things are outdated, and that's getting fixed in another PR. |
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflows to authenticate to GHCR using the built-in GITHUB_TOKEN (via github.token) instead of org-level GHCR secrets, aligning CI image workflows with the org’s secret-management changes.
Changes:
- Switched GHCR
docker/login-actioncredentials fromsecrets.GHCR_*to${{ github.actor }}/${{ github.token }}across multiple workflows. - Added explicit job
permissionsforpackages: writein the image build/push reusable workflow. - Corrected a GitHub Actions
if:expression for the version image build step.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| .github/workflows/unit_test.yml | Updates GHCR login to use ${{ github.actor }} / ${{ github.token }} for unit-test image pulls. |
| .github/workflows/integration_test.yml | Updates GHCR login to use ${{ github.actor }} / ${{ github.token }} for integration-test image pulls. |
| .github/workflows/tag_latest_image.yaml | Updates GHCR login to use ${{ github.actor }} / ${{ github.token }} for tagging/pushing “latest” images. |
| .github/workflows/build_and_push_image.yml | Adds packages: write permission and updates GHCR login; fixes a conditional expression for building the version image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
19
to
+23
| uses: docker/login-action@master | ||
| with: | ||
| registry: ghcr.io | ||
| username: ${{ secrets.GHCR_USERNAME }} | ||
| password: ${{ secrets.GHCR_TOKEN }} | ||
| username: ${{ github.actor }} | ||
| password: ${{ github.token }} |
Comment on lines
21
to
+23
| registry: ghcr.io | ||
| username: ${{ secrets.GHCR_USERNAME }} | ||
| password: ${{ secrets.GHCR_TOKEN }} | ||
| username: ${{ github.actor }} | ||
| password: ${{ github.token }} |
Comment on lines
19
to
+23
| uses: docker/login-action@master | ||
| with: | ||
| registry: ghcr.io | ||
| username: ${{ secrets.GHCR_USERNAME }} | ||
| password: ${{ secrets.GHCR_TOKEN }} | ||
| username: ${{ github.actor }} | ||
| password: ${{ github.token }} |
Comment on lines
21
to
+23
| registry: ghcr.io | ||
| username: ${{ secrets.GHCR_USERNAME }} | ||
| password: ${{ secrets.GHCR_TOKEN }} | ||
| username: ${{ github.actor }} | ||
| password: ${{ github.token }} |
Comment on lines
+16
to
+18
| permissions: | ||
| contents: read | ||
| packages: write |
Comment on lines
+54
to
+55
| username: ${{ github.actor }} | ||
| password: ${{ github.token }} |
Comment on lines
72
to
75
| name: Build version image | ||
| uses: docker/build-push-action@master | ||
| if: ${{ github.base_ref }} == 'main' || ${{ github.base_ref }} == 'develop' | ||
| if: ${{ github.base_ref == 'main' || github.base_ref == 'develop' }} | ||
| with: |
Comment on lines
22
to
+26
| uses: docker/login-action@master | ||
| with: | ||
| registry: ghcr.io | ||
| username: ${{ secrets.GHCR_USERNAME }} | ||
| password: ${{ secrets.GHCR_TOKEN }} | ||
| username: ${{ github.actor }} | ||
| password: ${{ github.token }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR purpose/changes
Fix the Github Actions that changed when the kbase org moved away from org secrets, specifically the image build and push workflow.