fix(ui): support hierarchical navigation in sidebar#16
Merged
Conversation
Add children support to NavItem interface and render parent-child
menu structure in the sidebar template.
- Add optional 'children' property to NavItem
- Render child items with indentation (pl-9) under parent items
- Set routerLinkActiveOptions { exact: true } for parent and child
items with children to prevent partial URL matching
- Move 'Ingest Jobs' as a child of 'Ingest' navigation item
This fixes the issue where navigating to /ingest/jobs would also
highlight the /ingest parent menu item, making the hierarchy unclear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the sidebar navigation to properly display parent-child hierarchy for the Ingest section.
Problem
When navigating to
/ingest/jobs, the/ingestmenu item was also highlighted due torouterLinkActive's default partial URL matching behavior. This made it look like both items were active and the hierarchy was unclear.Changes
childrenproperty toNavIteminterfacepl-9) under parent itemsrouterLinkActiveOptions: { exact: true }to parent and child items to prevent partial matchingVerification
pnpm exec ng build✅