Skip to content

fix: scope MD5 PASSWORD_HASHERS override to test runs only #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dan (danh91) merged 1 commit into from
Jun 23, 2026
Merged

fix: scope MD5 PASSWORD_HASHERS override to test runs only #1096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions apps/api/karrio/server/settings/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,13 +374,7 @@
}
}

# Speed up test suite: use fast MD5 hasher instead of bcrypt/PBKDF2
# This only applies when running `manage.py test` — production is unaffected
import sys as _sys
if "test" in _sys.argv or "karrio" in _sys.argv[0]:
PASSWORD_HASHERS = [
"django.contrib.auth.hashers.MD5PasswordHasher",
]
TEST_RUNNER = "karrio.server.test_runner.KarrioTestRunner"

if config("DATABASE_URL", default=None):
db_from_env = dj_database_url.config(
Expand Down
13 changes: 13 additions & 0 deletions apps/api/karrio/server/test_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
from django.conf import settings
from django.test.runner import DiscoverRunner


class KarrioTestRunner(DiscoverRunner):
"""Custom Django test runner that overrides settings for the test suite."""

def setup_test_environment(self, **kwargs):
super().setup_test_environment(**kwargs)
# Speed up tests with a fast hasher (PBKDF2 is intentionally slow).
settings.PASSWORD_HASHERS = [
"django.contrib.auth.hashers.MD5PasswordHasher",
]