add search function with more parameters

[lperlaki]

expose the scope and attrs parameter for search in search_with function

[nitnelave]

You could use the same impl Into<String> here, we don't otherwise use S

[lperlaki]

Yes we could do that but that would technically be a breaking change. And I don't now what the policy around that for this project is.

[nitnelave]

Would it really be a breaking change? What code would stop compiling? AFAIU this is equivalent syntactic sugar

[lperlaki]

Code that uses that explicitly uses that generic parameter like search::<String> would stop to compile

[nitnelave]

Fair enough. That's a bit of an edge case, but it is indeed a breaking change

[Firstyear]

I think this could get messy pretty fast if we keep adding parameters. I think perhaps we could consider a search builder pattern?

[lperlaki]

I think this could get messy pretty fast if we keep adding parameters. I think perhaps we could consider a search builder pattern?

yes I was thinking the same thing! in the latest commit the implementation is changed to the a builder pattern.
please let me know what you think about the design.
and for most use cases this new implementation is not a breaking change!