Read target address(es) from file#398
Open
FilippoRanza wants to merge 5 commits into
Open
Conversation
k4m4
requested changes
May 18, 2019
| @@ -0,0 +1,3 @@ | |||
| 192.168.0.2 | |||
Owner
There was a problem hiding this comment.
- I believe that this file is unnecessary
|
|
||
| def target_files(option, opt, value, parser): | ||
| with open(value) as file: | ||
| addr_list = file.readlines() |
Owner
There was a problem hiding this comment.
addressFileinstead ofaddr_list(camel case)
Author
There was a problem hiding this comment.
I update all names to camel case
|
|
||
| parser.add_option('-f', '--file', action='callback', | ||
| callback=target_files, type='string',metavar='FILE', | ||
| dest='targets', help='read target IP address(es), one per line, from given file and perform attack') |
Owner
There was a problem hiding this comment.
- I believe
read target IP address(es) from line-separated file and perform attacksounds better
Owner
|
Hi there. Thank you for this. Please have a look at my review. Also, it would be nice if you could change your commit messages to imperative - |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added -f option, that let the user specify target addresses from a file.