Fix AMD rocm#92
Open
Alexander-Ger-Reich wants to merge 3 commits into
Open
Conversation
Collaborator
|
It seems that to support AMD, we only need to install the corresponding Torch version and avoid using torchaudio? In the recent update, I switched the audio I/O from torchaudio to soundfile+librosa. So the only remaining task is to add instructions for installing the correct Torch version. If you find this is the case, maybe you could open a PR to add the Torch installation instructions under “Step 1: Install PyTorch”. |
Author
|
I am using the image provided by ROCm / AMD: FROM docker.io/rocm/pytorch:rocm7.2.2_ubuntu24.04_py3.12_pytorch_release_2.10.0
WORKDIR /app
# Install flash attention with triton backend
RUN FLASH_ATTENTION_TRITON_AMD_ENABLE=TRUE pip install flash-attention --no-build-isolation
# System deps
RUN apt-get update && apt-get install -y \
git \
ffmpeg \
&& rm -rf /var/lib/apt/lists/*
# Python deps - choose one
#RUN pip install --no-cache-dir omnivoice
RUN pip install git+https://github.com/k2-fsa/OmniVoice.git
# Startup
CMD ["omnivoice-demo", "--ip", "0.0.0.0", "--port", "8880"]
|
EnochPrime
reviewed
May 5, 2026
There was a problem hiding this comment.
You can avoid needed users to uncomment lines by using the optional dependencies methods like in #143.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this, it should work on AMD and NVIDIA graphics cards.