Skip fade and pad when postprocess_output is disabled#197
Open
SanjayMuthuswamy wants to merge 1 commit into
Open
Skip fade and pad when postprocess_output is disabled#197SanjayMuthuswamy wants to merge 1 commit into
SanjayMuthuswamy wants to merge 1 commit into
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
postprocess_output=False, this PR makes sure that all audio post-processing is skipped.Changes
fade_and_pad_audio()in the currentif postprocess_output:condition.postprocess_output.Inspiration
In the past, even when
postprocess_output=False,fade_and_pad_audio()was always used. Consequently, silence removal was skipped when post-processing was disabled, although fade-in/out and silent padding were still applied.This modification maintains the current default behavior (
postprocess_output=True) while making the behavior consistent.Fixes #194