Skip to content

fix: skip patch types that have no definition instead of throwing #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
divya0795 wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −2
Open

fix: skip patch types that have no definition instead of throwing #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions WandEnhancer/Core/Enhancer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,16 @@ private void PatchAsar()

foreach (var entry in remainingPatches.ToList())
{
var entries = enhancerConfig[entry];
// Not every EPatchType has an implementation in EnhancerConfig. Such a
// type stays in remainingPatches so it is reported by the summary below,
// rather than taking down the whole run with a KeyNotFoundException.
EnhancerConfig.PatchEntry[] entries;
if (!enhancerConfig.TryGetValue(entry, out entries))
{
_logger($"[ENHANCER] No patch definition for {entry}, skipping", ELogType.Warn);
continue;
}

foreach (var patchEntry in entries)
{
bool patchApplied;
Expand Down Expand Up @@ -189,7 +198,13 @@ private static bool CouldFileContainRemainingPatch(string filePath, IEnumerable<
{
foreach (var patchType in remainingPatches)
{
foreach (var patchEntry in enhancerConfig[patchType])
EnhancerConfig.PatchEntry[] entries;
if (!enhancerConfig.TryGetValue(patchType, out entries))
{
continue;
}

foreach (var patchEntry in entries)
{
if (patchEntry.Applied)
{
Expand Down