Skip to content

ci: judge docs/ too, after a pinned pair half-landed and broke it - #17

Merged
tannevaled merged 1 commit into
masterfrom
ci-docs
Sep 6, 2026
Merged

tannevaled merged 1 commit into
masterfrom
ci-docs

Conversation

@tannevaled

Copy link
Copy Markdown
Contributor

The install job says nothing about docs/, and that gap has already cost something.

mkdocs-material was raised to 9.7.7 (#14, #15) while mkdocs stayed at 1.5.3, which makes docs/requirements.txt unresolvable:

pip install -r docs/requirements.txt
ERROR: ResolutionImpossible

9.7.7 needs mkdocs >= 1.6. The two are a pinned pair; neither half can land alone. But the lane judged the package and not the documentation, so both halves went green and only one merged. #13 was the other half — master is repaired now.

I did that, minutes after adding the lane that should have caught it, one directory over.

step proves
pip install -r docs/requirements.txt the pinned docs dependencies install together — catches half a pair moving alone
mkdocs build the site builds with those versions

Not --strict, deliberately: strict mode currently fails on a pre-existing nav warning (SUPPORT.md referenced in mkdocs.yml, absent from the tree) with nothing to do with any dependency. A step red on arrival is one people learn to ignore — fix that warning and --strict becomes the better check.

Verified: with master as it now stands both steps pass; with mkdocs pinned back to 1.5.3, step 1 fails as it should.

🤖 Generated with Claude Code

The install job says nothing about docs/, and that gap has already cost
something. mkdocs-material was raised to 9.7.7 (#14, #15) while mkdocs stayed
at 1.5.3, which makes docs/requirements.txt unresolvable:

    pip install -r docs/requirements.txt
    ERROR: ResolutionImpossible

9.7.7 needs mkdocs >= 1.6. The two are a pinned pair and neither half can land
alone -- but the lane judged the package, not the documentation, so both halves
went green and only one of them merged. #13 was the other half; master is
repaired now.

I did that. The lane I added a few minutes earlier is exactly what should have
caught it, one directory over.

Two steps:

  pip install   the pinned docs dependencies can be installed TOGETHER, which
                is what catches half of a pair moving on its own
  mkdocs build  the site builds with those versions

Not --strict, deliberately: strict mode currently fails on a pre-existing nav
warning (SUPPORT.md referenced in mkdocs.yml and absent from the tree), which
has nothing to do with any dependency. A step that is red on arrival is one
people learn to ignore. Fix that warning and --strict becomes the better check.

Verified locally: with master as it now stands, both steps pass; with
mkdocs pinned back to 1.5.3, step 1 fails as it should.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@tannevaled
tannevaled merged commit aa0a26e into master Sep 6, 2026
3 checks passed
@tannevaled
tannevaled deleted the ci-docs branch September 6, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant