Repository navigation
ci: judge docs/ too, after a pinned pair half-landed and broke it - #17
Merged
Merged
Conversation
The install job says nothing about docs/, and that gap has already cost something. mkdocs-material was raised to 9.7.7 (#14, #15) while mkdocs stayed at 1.5.3, which makes docs/requirements.txt unresolvable: pip install -r docs/requirements.txt ERROR: ResolutionImpossible 9.7.7 needs mkdocs >= 1.6. The two are a pinned pair and neither half can land alone -- but the lane judged the package, not the documentation, so both halves went green and only one of them merged. #13 was the other half; master is repaired now. I did that. The lane I added a few minutes earlier is exactly what should have caught it, one directory over. Two steps: pip install the pinned docs dependencies can be installed TOGETHER, which is what catches half of a pair moving on its own mkdocs build the site builds with those versions Not --strict, deliberately: strict mode currently fails on a pre-existing nav warning (SUPPORT.md referenced in mkdocs.yml and absent from the tree), which has nothing to do with any dependency. A step that is red on arrival is one people learn to ignore. Fix that warning and --strict becomes the better check. Verified locally: with master as it now stands, both steps pass; with mkdocs pinned back to 1.5.3, step 1 fails as it should. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The install job says nothing about
docs/, and that gap has already cost something.mkdocs-materialwas raised to 9.7.7 (#14, #15) whilemkdocsstayed at 1.5.3, which makesdocs/requirements.txtunresolvable:9.7.7 needs
mkdocs >= 1.6. The two are a pinned pair; neither half can land alone. But the lane judged the package and not the documentation, so both halves went green and only one merged. #13 was the other half —masteris repaired now.I did that, minutes after adding the lane that should have caught it, one directory over.
pip install -r docs/requirements.txtmkdocs buildNot
--strict, deliberately: strict mode currently fails on a pre-existing nav warning (SUPPORT.mdreferenced inmkdocs.yml, absent from the tree) with nothing to do with any dependency. A step red on arrival is one people learn to ignore — fix that warning and--strictbecomes the better check.Verified: with
masteras it now stands both steps pass; withmkdocspinned back to 1.5.3, step 1 fails as it should.🤖 Generated with Claude Code