Skip to content

Comments

made the server run on env-port to make it compatible with azure#1

Open
thsorens wants to merge 2 commits intojstclair:latestfrom
thsorens:ProdDeploy
Open

made the server run on env-port to make it compatible with azure#1
thsorens wants to merge 2 commits intojstclair:latestfrom
thsorens:ProdDeploy

Conversation

@thsorens
Copy link

Used pretty much a day to figure out how to make this work on azure, which doesnt give much feedback on whats going wrong. Azure doesnt like to not be the master of ports, so this solves that issue.

@jstclair
Copy link
Owner

This is fine, other than a little 💄

I could have told you about the PORT :) That's typically the things you need to do for actual hosting - I'm just not sure if we want this bootstrap to be "ready-to-go" (for full production hosting) or "easy-to-follow". if the former, we have a long way to go (error handling, etc.) And we don't even have a good business issue (to iterate further on the bootstrap - like for adding reflux).

@thsorens
Copy link
Author

There is also an issue with the sass-loader in production settings. It doesnt really transpile the sass, so you end up with a css-file with sass in it, shall i put in a pull-req for that as well? You decide if you want to add the env-port change, just thought it might save someone else some possible hours of frustration;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants