made the server run on env-port to make it compatible with azure#1
Open
thsorens wants to merge 2 commits intojstclair:latestfrom
Open
made the server run on env-port to make it compatible with azure#1thsorens wants to merge 2 commits intojstclair:latestfrom
thsorens wants to merge 2 commits intojstclair:latestfrom
Conversation
Owner
|
This is fine, other than a little 💄 I could have told you about the PORT :) That's typically the things you need to do for actual hosting - I'm just not sure if we want this bootstrap to be "ready-to-go" (for full production hosting) or "easy-to-follow". if the former, we have a long way to go (error handling, etc.) And we don't even have a good business issue (to iterate further on the bootstrap - like for adding reflux). |
Author
|
There is also an issue with the sass-loader in production settings. It doesnt really transpile the sass, so you end up with a css-file with sass in it, shall i put in a pull-req for that as well? You decide if you want to add the env-port change, just thought it might save someone else some possible hours of frustration;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used pretty much a day to figure out how to make this work on azure, which doesnt give much feedback on whats going wrong. Azure doesnt like to not be the master of ports, so this solves that issue.