Repository navigation
Conversation
…rule into pr-review prompt ai-01|CoursIA asked the hermes-agent workspace (global dashboard ASK 08:50Z, arbitrage user 2026-09-24) to apply the new README-totals review rule. The rule lands in CoursIA .claude/rules/pr-review-discipline.md via PR NousResearch#17633 (still open, and main still carries the superseded "audit fichier entier" clause), so the rule is inlined into the bot's pr-review prompt by an idempotent restore section 5f. Two defects were found by exercising 5f live in the container rather than trusting the diff: - the first version keyed its guard on a marker string that never matched the injected heading, so every run appended a new copy (two blocks in jobs.json); - the block text contained backticks, which this python source sits inside a double-quoted bash string -> the shell command-substituted them before python ever saw the text. Section 5f therefore normalizes (strip any existing copy, re-append one canonical block) instead of append-if-absent, and carries no backticks. Verified live: run 1 rewrites to a single block, run 2 is a no-op. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
૮ >ﻌ< ა ci reviewran on 8cb2a9a — fix(restore,NousResearch#17633): inline CoursIA README-totals review rul ❌ Job failuresPython lints / Windows footguns (blocking) · View jobJob Python lints / Windows footguns (blocking) failed. Python lints / ruff enforcement (blocking) · View jobJob Python lints / ruff enforcement (blocking) failed.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ai-01|CoursIA asked the hermes-agent workspace (global dashboard
[ASK]2026-09-24 08:50Z, arbitrage user) to apply the new README-totals review rule for CoursIA README PRs. The canonical rule lands in CoursIA.claude/rules/pr-review-discipline.mdvia jsboige/CoursIA#17633, which is still open — andmainstill carries the superseded clause ("audit fichier ENTIER des comptes", §E) that the new rule retires.So the rule is inlined into the bot's
hermes-pr-reviewprompt by a new idempotent restore section 5f, taking effect immediately and surviving rebuilds (prompts are not regenerated elsewhere — same pattern as 5b/5c/5e).What the directive says
CHANGES_REQUESTED. Those numbers belong to catalogue regeneration (CATALOG-STATUS, feat: add opencode-zen model provider with live model fetch NousResearch/hermes-agent#2651): a wrong count line is deleted, not refreshed.Two defects found by exercising 5f live, not by reading the diff
README-TOTALS #17633…vsREADME-TOTALS CoursIA #17633…), so every run appended a new copy — two blocks observed injobs.json.gh: accepts 1 arg(s), received 2).Fix: 5f normalizes (strip any existing copy with a tolerant regex, re-append one canonical block) instead of append-if-absent, and carries no backticks.
Test plan
Exercised live in the container against
/opt/data/cron/jobs.json:(re)applied, prompt converges to a single canonical blockalready canonical (no-op)(true idempotence)sh -nsyntax OK, pure LF, no deletions in the diff (claudish-hub sections untouched)192.168.0.50:3000hub lines still present (×4) — the 15/09 claudish-2 bascule is not reverted🤖 Generated with Claude Code