Repository navigation
docs(gametheory): comprehensive audit + README fixes (#622) - #627
Conversation
- Add INVENTORY.md: comprehensive audit of 29 notebooks (17 main + 12 side) - Fix README: correct count 27->29, add missing 16f-SocialChoice-Z3 entry - Fix README: add side track type f (Social Choice via Z3 solver) - Fix README: update total duration to ~19h15 - Fix GT-8b footer: correct broken navigation links (19b->8c, 20->index) - Audit results: 0 NotImplementedError, 0 errors, 26 null exec (all expected) - Lean sorry counts stable: Arrow(0), Sen(0), Framework(0), Voting(3) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
jsboige
left a comment
There was a problem hiding this comment.
Review: PR #627 — docs(gametheory): Comprehensive Audit + README Fix
Verdict: APPROVE with minor comments
Clean documentation PR. No contamination detected.
Contamination Check: PASS
- No submodule bumps
- No unrelated file changes
- All 3 files are documentation: README fix, notebook footer fix, new INVENTORY.md audit report
Per-File Review
1. MyIA.AI.Notebooks/GameTheory/README.md — GOOD
- Fixes notebook count: 27 -> 29 (adds missing 16f).
- Adds 16f-SocialChoice-Z3 entry to the Partie 3 table with correct description and duration.
- Updates total duration: 18h30 -> 19h15 (45 min addition for 16f, consistent).
- Adds
fside track to the legend table. - Adds 16f to the completion status table ("~20 cells, 2 exercises, COMPLET").
- Adds 16f to the file tree listing.
- Note: The description says "d/e/f = Social Choice" but
eis actually Lean 4 (DominikPeters tour), not Python Social Choice. The legend table below correctly identifieseas Lean 4, so the header summary is slightly misleading but the detail is correct. Low priority.
2. MyIA.AI.Notebooks/GameTheory/GameTheory-8b-Lean-CombinatorialGames.ipynb — GOOD
- Fixes the broken footer navigation links identified in the audit.
- "Notebook 19b" -> "8c-CombinatorialGames-Python" (correct side track).
- "Notebook 20" -> "Index" (correct landing page).
- "<- GameTheory-4b-Lean-NashExistence" -> "<- 8-CombinatorialGames" (correct parent notebook).
- Per CLAUDE.md rules: I sampled the full cell diff — it's a single markdown cell replacing stale navigation. Pedagogical intent is preserved (same Resume table, same "Pour aller plus loin" section, updated links only). The LaTeX escaping change (
\\{0|\\}->{0\\|1}) is a cosmetic side effect of the cell being re-serialized as a single JSON string rather than an array — functionally equivalent.
3. MyIA.AI.Notebooks/GameTheory/INVENTORY.md — GOOD
- Comprehensive 223-line audit report covering all 29 notebooks, 4 Lean projects, 3 Python modules, tests, and infrastructure.
- 5-point audit structure follows CLAUDE.md requirements.
- Key findings are well-documented: 16f missing from README (now fixed in this PR), GT-8b footer links broken (now fixed), GT-8 thin for 55-min claim (flagged as optional expansion).
- Lean sorry counts match known stable state from audit #538.
- 26 null execution cells all categorized and explained.
Observations (non-blocking)
- INVENTORY.md is a snapshot — It will drift as notebooks evolve. Consider whether this should be regenerated periodically or if it's a one-time audit artifact.
- GT-8 thin content flagged in the audit (8 code cells for 55-min claim) is not addressed in this PR — correctly deferred as optional. No action needed.
- README header inconsistency: "d/e/f = Social Choice" is technically wrong (e = Lean). The legend table below is correct, so this is cosmetic only.
|
[DONE] lane myia-po-2024:CoursIA -- cycle ~307 (20/10 ~06:2xZ) Grain #21489 LIVRE -- PR #21547 (fix/21489-dedup-cles, head f530d8a) : acceptance complete (organe check_duplicate_keys.py + garde fast_lane_registry.py blocking + verdict DUPLICATE_KEY dans check_translation_sync.py + passe --resolve : occurrence conforme au notebook / derniere / fusion cibles non vides). Mesures : ml-datascience 950->782 (168 cles, 0 valeur perdue) ; planners 1119->1050 (69 cles, 0 valeur perdue) ; T1 --update 2e passe = 0 rafraichi (idempotence atteinte) ; 54+8 tests verts ; claim c.6284515534 ; [DELIVERED] c.6284721375. Recette #20386 = FAUX NEGATIF organe : le dernier commentaire (19/10 22:00Z) est le tour de MA lane (socle critique 3D-02, c.6278326460) -- recette_due.py rend "jamais" (stale-zero). Pas de nouveau tour : servi <24 h, balle chez Pierre depuis le 12/10. Externes : #21535 OPEN (main rouge 15/14) ; #21025 rerun re-queued (famine) ; #21542/#21537/knot_lean jambes en file ; umbrella b2trw3242 vivant. Cron de session : ae199a14 (13,43 * * * *) -- inchange. |
|
[DONE] Roster po-2028 -- lane myia-po-2024:CoursIA (20/10 ~08:4xZ) Geste roster po-2028 execute : 1 occurrence |
|
[DONE] lane myia-po-2024:CoursIA -- cycle ~308 (20/10 ~09:0xZ) Mission HIGH roster po-2028 EXECUTEE : ROO_FLEET_ROSTER mis a jour dans ~/.claude.json (1 occurrence, chaine canonique 9 machines verbatim, JSON valide). .env : aucune occurrence. Backups poses. DONE c.6284981135. Grain #21545 LIVRE -- PR #21550 (fix/21545-search11-conclusion, head b4193af) : conclusion du temps de calcul derivee de l'exposant empirique (if/elif sur ordre, plus jamais imprimee en dur), re-exec Papermill python3 exit 0, cellules voisines revues (c39/c42 pop_size = conclusion "lineaire" correcte). Claim c.6285080261, DELIVERED c.6285177957. P0 -- 4 CHANGES_REQUESTED traitees : #21547 body reecrit (re-seeding T1 84+2 carnets documente separement du resolve, reponse B.0 c.6285226870) ; #21544 attestation twin 0035 confirmee livree post-review (commit 1396b32, reponse B.0 c.6285263185) ; #21528 fermee (regle #18911 inversee le 09/10, meme sort que les 5 soeurs #21400-#21404) ; #21520 B1+B2 fixes (bandeau TorchLean public + valeur fc2 -1.25, commit c7ac2f0, reponse B.0 c.6285325421 ; M3 extern reste ouvert, documente). Umbrella Knots build SUCCESS : 3048 jobs, 0 erreur (Knots 49s, Knots_en 103s) -- attestation locale du fix collision #21414/#21434. Externes inchanges : #21535 OPEN (main rouge 15/14) ; #21025 rerun queued (famine) ; #21542 APPROVED 0 FAILURE (merge ai-01) ; #21414 Lean CI SUCCESS (merge ai-01) ; #21434 Lean CI IN_PROGRESS. Cron de session : ae199a14 (13,43 * * * *) -- inchange. |
Summary
Audit Results (5-point review, CLAUDE.md sec B)
Files Changed
MyIA.AI.Notebooks/GameTheory/INVENTORY.md(NEW) — Full audit reportMyIA.AI.Notebooks/GameTheory/README.md— Count fix + 16f entry + duration updateMyIA.AI.Notebooks/GameTheory/GameTheory-8b-Lean-CombinatorialGames.ipynb— Footer fixCloses #622
Test plan
notebook_tools.py analyze— 0 errors across all 29 notebooks🤖 Generated with Claude Code