Skip to content

fix(notebooks,#18718): Causal-Bridges -- interieurs repointes sur la numerotation #17421 (markdown-only) - #18720

Merged
myia-ai-01 merged 1 commit into
mainfrom
fix/18718-causal-bridges-interieurs
Oct 2, 2026
Merged

myia-ai-01 merged 1 commit into
mainfrom
fix/18718-causal-bridges-interieurs

Conversation

@jsboige

@jsboige jsboige commented Oct 1, 2026

Copy link
Copy Markdown
Owner

Grain: MED/notebook-python — lane myia-po-2023:CoursIA — prev: MED/notebook-python #18715

Résumé

La renumérotation #17421 (10fb5074cb) a rebaptisé la série DoWhy → CausalBridges-01..08 (fichiers, hrefs, README), mais les intérieurs des carnets citaient encore les anciens numéros. Cette PR repointe ces intérieurs sur la numérotation courante, markdown uniquement.

Contenu (7 carnets, 25 lignes, édition chirurgicale)

Carnet Éditions
01-Do-Calculus 1 renvoi (§5 de DoWhy-5) → CausalBridges-06
02-Estimand titre md[0] : # DoWhy-1 — … → # CausalBridges-02 — … + erratum de renumérotation
03-Contrefactuel titre + erratum ; 5 renvois prose (prérequis, table Rung, « la suite de la série », etc.)
04-Decouverte titre + erratum ; 6 renvois prose (constellation, §4, NON_IDENTIFIABLE dans DoWhy-5, question laissée ouverte)
05-Sensibilite titre + erratum ; 4 renvois prose (intro, footer série complet)
06-Instrument titre + erratum ; 3 renvois prose (prérequis, lien avec DoWhy-3)
08-Fairness 2 labels de liens [DoWhy-1](…) → [CausalBridges-02 (ex-DoWhy-1)](…) (hrefs déjà corrects)

Chaque titre reçoit une ligne d'erratum : > Renumerotation #17421 : ce carnet etait publie sous le nom DoWhy-N ; les renvois internes de la serie citent desormais le numero courant. — le sous-titre d'origine reste sur la ligne de titre.

Tri outil / carnet (les occurrences NON touchées, par design)

  • dowhy minuscule (ex. 06 « dowhy identifie », commentaires code) = la librairie → intacts (garde vérifiée par assert).
  • Lignes **Série** : Inférence causale avec DoWhy (Probas, Python) = intitulé de série citant l'outil → intactes.
  • DoWhy-N majuscule-numéro = l'ex-carnet → repointé partout en prose/markdown.

Non-touchés (documentés, voir aussi commentaire sur #18718)

  1. Commentaires code cell[1] de 04 et 06 : # L'organe canonique de la serie dowhy … -- DoWhy-N (issue #14049). Ils citent la provenance des organes [Probas] Serie DoWhy : planifier DoWhy-2 a DoWhy-5 -- le "-1" est une promesse non tenue #14049, dont les fichiers sont toujours nommés dowhy_discovery_organs.py / dowhy_iv_organs.py. Les éditer modifierait une cellule code → re-exécution due (C.2) des deux carnets dowhy pour un gain nul. Laissés intacts délibérément.
  2. metadata.papermill.output_path citant un ancien stem (DoWhy-2-…_output.ipynb) dans 03 : metadata, pas une sortie (tolérance règle 6), aucune re-exécution due pour une PR markdown-only.

Validation

  • Éditions par remplacement textuel dans le JSON brut (raw.count(old)==1 asserté avant chaque remplacement — leçon notebook-edit-rawtext) : diff 25 insertions / 25 délétions sur 7 fichiers, aucun round-trip json.dump.
  • json.loads OK sur les 8 carnets après édition.
  • Scan résiduel DoWhy-\d : 0 occurrence hors erratums (« publie sous le nom DoWhy-N »), labels « (ex-DoWhy-1) », commentaires organe ci-dessus et metadata papermill.
  • Markdown-only : aucune cellule code modifiée → exception C.2 (pas de re-exécution due), pre-commit H.3 vert au commit (ba4155c608).

See #18718

🤖 Generated with Claude Code

…nte (#17421)

Titres md[0] des carnets 02-06 (ex-DoWhy-1..5) + erratum de renumerotation,
renvois prose et labels de liens repoints sur les numeros courants.
Markdown-only (exception C.2), editions textuelles chirurgicales dans le JSON
brut (lecon notebook-edit-rawtext), diff 25 lignes sur 7 fichiers.

See #18718

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

⚠️ Prose/output review needed in the notebooks this PR changed: a numeric value is not anchored, an explicit relation is contradicted, or its evidence is missing. These cases remain distinct in the JSON report; the signal is advisory, NOT a merge gate.

Scope = notebooks CHANGED in this PR, not the whole corpus. Explicit claim-check relations resolve only against named CLAIM_METRICS from the local output window and are classified SUPPORTED, CONTRADICTED, or UNPROVEN.
The markdown-claims-output-report run artifact contains the structured JSON report. See python scripts/check_markdown_claims_output.py --help for re-running locally.
Detector rationale: c.290 / c.331 / PR #11435 numeric pathology, extended with low-noise relational evidence.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

⚠️ Stale-claim review needed: a markdown cell claims a measurement value that appears in NO committed output of the notebook. Advisory, NOT a merge gate — triage against the JSON artifact.

Scope = notebooks CHANGED in this PR, not the whole corpus. The stale-claim-report run artifact holds the structured JSON.
Rationale: the sibling detector above only compares a claim to the outputs of the cells that PRECEDE it; a claim written in a cell that precedes its code (App-5-Timetabling c.2/c.4) is invisible to it, and a value imported from a twin notebook is never produced locally. See python scripts/check_stale_claims.py --help.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

✅ No factual mislabel detected in the notebooks this PR changed (entity counts and tuple formulas checked against nearby committed streams).

Scope = notebooks CHANGED in this PR, not the whole corpus. The factual-mislabel-report run artifact holds the structured JSON.
Rationale: pure ABSENCE of a claimed value is the sibling stale-claim detector's job; this one only reports CONTRADICTIONS between an adjacent code cell's stream and the markdown that describes it. See python scripts/check_factual_mislabel.py --help.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

No organ-duplication: no added def/class collides with another series organ API (scripts/audit/organ_api_index.yaml).

Detector: python scripts/audit/detect_organ_duplication.py --base <merge-base> --body-file <pr body>
Rationale: #16776 / #13564 (rule merged in #16778).

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Notebook PR Validation: PASS

  • Notebooks checked: 7
  • Code cells validated: 91
  • Result: All passed

Checks: H.1 (no errors), H.3 (execution_count), C.1 (no banned patterns)
Non-Python kernels (.NET/Lean): C.1 + errors only (execution_count advisory)
QuantConnect notebooks: C.1 + errors only (require QC Cloud for execution)

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Notebook outputs-required (H.4 schema): PASS (every code cell carries an outputs: list)

@github-actions github-actions Bot added the variation-adjacency-deep-med Adjacence DEEP/MED hors LIGHT : §2 l'autorise si substance distincte (coordinateur) label Oct 1, 2026
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Golden-Set Execution (H.7 P3)

✅ 8/8 notebooks passed (certified reproducible)

Notebook Status Time
2.1-Workflow-ML.ipynb ✅ SUCCESS 4.3s
2.2-Descente-de-gradient.ipynb ✅ SUCCESS 4.0s
2.3-Regression-lineaire-logistique.ipynb ✅ SUCCESS 4.8s
2.4-Arbres-Forets-Ensembles.ipynb ✅ SUCCESS 4.6s
Search-01-StateSpace.ipynb ✅ SUCCESS 3.9s
SL-1-LogicalLearning.ipynb ✅ SUCCESS 3.0s
rl_4_multi_armed_bandits.ipynb ✅ SUCCESS 16.4s
GameTheory-04c-NashExistence-Python.ipynb ✅ SUCCESS 3.4s

Pinned lockfile: scripts/notebook_tools/golden_set.lock.txt (H.7 P3, axe A #4208)

@jsboige

jsboige commented Oct 2, 2026

Copy link
Copy Markdown
Owner Author

[ADJOINT PREFLIGHT]
schema: 1
lane: myia-po-2026:CoursIA-3
pr: 18720
head: ba4155c
complete: true
body: read
comments-reviewed: 7
reviews-reviewed: 0
threads-reviewed: 0
threads-unresolved: 0
surfaces-sha256: 19011e2dcfec87f78a428f88549e0dbb98dc30489d10fcadaafa1d17b07ea5d7
diff-files: 7
diff-additions: 25
diff-deletions: 25
checks: latest-wins-green
b0: clear
scope: pass
domain: pass
verdict: READY
[/ADJOINT PREFLIGHT]

@myia-ai-01
myia-ai-01 merged commit c96fb17 into main Oct 2, 2026
90 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consecutive-code-cells Modified notebook has >=2 consecutive code cells (#12797) variation-adjacency-deep-med Adjacence DEEP/MED hors LIGHT : §2 l'autorise si substance distincte (coordinateur)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants