Skip to content

fix(notebooks,#17550): Z3-12-Real-Arithmetic-Python — 1 cellule markdown nettoyee du doublage de newlines - #18237

Merged
myia-ai-01 merged 2 commits into
mainfrom
fix/17550-z312-real-arith-newlines
Sep 29, 2026
Merged

myia-ai-01 merged 2 commits into
mainfrom
fix/17550-z312-real-arith-newlines

Conversation

@jsboige

@jsboige jsboige commented Sep 28, 2026

Copy link
Copy Markdown
Owner

Grain: DEEP/notebook-python -- lane myia-po-2026:CoursIA-2 -- prev: DEEP/notebook-python #18236

Issue

#17550 acceptance (grain « Z3-12-Real-Arithmetic-Python », tranche 7/16) : 1 cellule markdown porte la signature exacte « odd-index toutes '\n' EXACTEMENT + ≥5 éléments + ≥3 non-vides ».

Cells touchées (1 markdown, 0 code)

# Source lines avant → après Caractères avant → après
0 9 → 5 1106 → 1102

Acceptance

  • Carnet traité : Z3-12-Real-Arithmetic-Python.ipynb (tranche 7/16).
  • Texte normalisé identique cellule par cellule.
  • Pas de cellule code touchée → pas de ré-exécution Papermill due.
  • pre-commit 8 hooks OK. git diff --stat : 1 file, +1/-5. Pure suppression (le +1 = fermeture JSON).

Co-Authored-By: Claude Haiku 4.5 (1M context) noreply@anthropic.com

See #17550

…own nettoyee du doublage de newlines

Co-Authored-By: Claude Haiku 4.5 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Prose/output review needed in the notebooks this PR changed: a numeric value is not anchored, an explicit relation is contradicted, or its evidence is missing. These cases remain distinct in the JSON report; the signal is advisory, NOT a merge gate.

Scope = notebooks CHANGED in this PR, not the whole corpus. Explicit claim-check relations resolve only against named CLAIM_METRICS from the local output window and are classified SUPPORTED, CONTRADICTED, or UNPROVEN.
The markdown-claims-output-report run artifact contains the structured JSON report. See python scripts/check_markdown_claims_output.py --help for re-running locally.
Detector rationale: c.290 / c.331 / PR #11435 numeric pathology, extended with low-noise relational evidence.

@github-actions

Copy link
Copy Markdown
Contributor

No organ-duplication: no added def/class collides with another series organ API (scripts/audit/organ_api_index.yaml).

Detector: python scripts/audit/detect_organ_duplication.py --base <merge-base> --body-file <pr body>
Rationale: #16776 / #13564 (rule merged in #16778).

@github-actions

Copy link
Copy Markdown
Contributor

Notebook outputs-required (H.4 schema): PASS (every code cell carries an outputs: list)

@github-actions github-actions Bot added the variation-adjacency-deep-med Adjacence DEEP/MED hors LIGHT : §2 l'autorise si substance distincte (coordinateur) label Sep 28, 2026
@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Golden-Set Execution (H.7 P3)

✅ 8/8 notebooks passed (certified reproducible)

Notebook Status Time
2.1-Workflow-ML.ipynb ✅ SUCCESS 5.8s
2.2-Descente-de-gradient.ipynb ✅ SUCCESS 7.1s
2.3-Regression-lineaire-logistique.ipynb ✅ SUCCESS 8.6s
2.4-Arbres-Forets-Ensembles.ipynb ✅ SUCCESS 7.2s
Search-01-StateSpace.ipynb ✅ SUCCESS 5.6s
SL-1-LogicalLearning.ipynb ✅ SUCCESS 4.5s
rl_4_multi_armed_bandits.ipynb ✅ SUCCESS 50.6s
GameTheory-04c-NashExistence-Python.ipynb ✅ SUCCESS 5.4s

Pinned lockfile: scripts/notebook_tools/golden_set.lock.txt (H.7 P3, axe A #4208)

@github-actions

Copy link
Copy Markdown
Contributor

Notebook PR Validation: PASS

  • Notebooks checked: 1
  • Code cells validated: 8
  • Result: All passed

Checks: H.1 (no errors), H.3 (execution_count), C.1 (no banned patterns)
Non-Python kernels (.NET/Lean): C.1 + errors only (execution_count advisory)
QuantConnect notebooks: C.1 + errors only (require QC Cloud for execution)

@clusterManager-Myia clusterManager-Myia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERDICT: LGTM

Nettoyage newlines série #17550, vérifié au-delà du diff :

  • Diff intégral : 5 retraits, tous des entrées "\n" autonomes de la cellule d'en-tête [00] + newline final du fichier. Zéro contenu, zéro code, zéro output touchés.
  • Full read au head (vue structurelle, 25 cellules) : aucun header dupliqué, pas de prose empilée, les 8 cellules de code portent leurs outputs (imports + 5 démos + 3 exercices « à compléter » sans fuite de solution).
  • Rendu préservé : # 12. reste un heading ATX valide, le > Port pyz3 reste un blockquote ; les phrases de prose de l'en-tête fusionnent en paragraphe continu, conforme au gabarit de la série.
  • Preuve-vive checks : « Notebooks checked: 1 / Code cells validated: 8 » = bien CE notebook (8 cellules de code du fichier changé), Golden-Set 8/8 ; l'advisory claims a réellement lu le notebook changé — le chemin scanné s'exécute sur cette PR.
  • Advisory ⚠️ non bloquant : concerne des valeurs préexistantes hors cellules touchées — la lecture [09] cite 1.999999999793256 et 2e-10 absents des outputs ; arithmétique recalculée à la main : 1.4142135623² ≈ 1.9999999998, claim exact mais non ancré. À traiter dans la série d'ancrage, pas dans cette PR d'espacement.

[Hermes hermes-pr-review, cycle :14 28/09, host f6be46d1b7a3, sig=5b6f70f2]

@github-actions

Copy link
Copy Markdown
Contributor

Path-collision (organ #13359/#13615)

Cette PR #18237 (fix(notebooks,#17550): Z3-12-Real-Arithmetic-Python — 1 cellule markdown nettoyee du doublage de newlines) touche au moins un chemin de fichier aussi modifie par d'autres PRs ouvertes. Risque de double-livraison (meme fichier livre deux fois, 2x le travail et 2x les runs CI). Advisory : parfois legitime (tranches coordonnees, partition paths: explicite, PRs empilees exclues) -- l'organe rend visible, il ne bloque pas.

@jsboige

jsboige commented Sep 29, 2026

Copy link
Copy Markdown
Owner Author

[ADJOINT PREFLIGHT]
schema: 1
lane: myia-po-2026:CoursIA-3
pr: 18237
head: 52c8e1c
complete: true
body: read
comments-reviewed: 6
reviews-reviewed: 1
threads-reviewed: 0
threads-unresolved: 0
surfaces-sha256: 01385458bca487ecc54ff1c25a1b7cd07f195fad415a478e54a1c81888a1b486
diff-files: 1
diff-additions: 1
diff-deletions: 5
checks: latest-wins-green
b0: clear
scope: pass
domain: pass
verdict: READY
[/ADJOINT PREFLIGHT]

Secrétaire vérificateur (myia-po-2026:CoursIA-3), 29/09 00:50Z — Dossier tiers READY à tête exacte 52c8e1cf. Vague oldest-first #18202-#18317 (dispatch ai-01 28/09 22:22Z).

  • Tête exacte : 52c8e1cf68757885bc22f35a2529c459cd2cec1a — vérifiée via check-runs.
  • Checks : 0 rouge latest-wins (markdown-only, ~108 jambes vertes).
  • B.0 : check_unaddressed_nits.py rc=0.
  • Scope : fix Z3-12-Real-Arithmetic-Python — 1 cellule markdown.
  • Risque résiduel : néant — modifs markdown pures (C.2 exception markdown, pas de re-exec due).
  • Geste attendu ai-01 : merge direct via Q67 (APPROVED à la tête lue).

@myia-ai-01
myia-ai-01 merged commit 4bd63fc into main Sep 29, 2026
90 of 92 checks passed
jsboige added a commit that referenced this pull request Sep 29, 2026
… nettoyage newlines (main #18237)

Cellule 0 des deux carnets: la branche portait la chaine de navigation
(#17419), main portait le de-doublement des sauts de ligne (#18237).
Union verifiee cote par cote (chaque cote ne touche que sa ligne/c'est
la premiere ligne pour la nav), JSON valide, check_notebook_nav_chain:
0 finding Z3-API post-merge.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

variation-adjacency-deep-med Adjacence DEEP/MED hors LIGHT : §2 l'autorise si substance distincte (coordinateur)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants