Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion scripts/notebook_tools/scan_enrich_quality.py
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,15 @@ def scan_anchors(cells: list[dict]) -> list[dict]:
continue
seen.add(idx)
if idx >= n_code:
abs_state = "markdown" if idx < n and cells[idx].get("cell_type") == "markdown" else "out of notebook"
# Libelle exact (#17875, second defaut) : la cellule absolue
# peut EXISTER et etre du code -- dire "out of notebook" pour
# une cellule presente gonfle l'alarme au-dela du fait.
if idx >= n:
abs_state = "out of notebook"
elif cells[idx].get("cell_type") == "markdown":
abs_state = "markdown"
else:
abs_state = "a code cell"
findings.append({
"cell_index": i, "category": "ANCHOR_OOR", "severity": "HIGH",
"evidence": m.group(0),
Expand Down
22 changes: 22 additions & 0 deletions scripts/notebook_tools/tests/test_scan_enrich_quality.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,28 @@ def test_correct_code_index_anchor_is_silent(self):
cells = [_md("# Titre"), _code("a"), _md("interp de code[0]")]
assert scan_anchors(cells) == []

def test_oor_label_reports_the_actual_carrier_state(self):
# #17875 second defaut : le libelle abs_state etait binaire
# ("markdown" / "out of notebook") -- une cellule de code PRESENTE a
# l'index absolu etait annoncee "out of notebook". Le libelle doit
# rendre l'etat reel du porteur : code existant, markdown, ou
# reellement au-dela du carnet.
# code_abs = [1, 2, 3], n_code = 3 : code[3] est OOR et la cellule
# absolue 3 EXISTE (code).
code_carrier = [_md("voir code[3]"), _code("a"), _code("b"), _code("c")]
msg = scan_anchors(code_carrier)[0]["message"]
assert "absolute cell 3 is a code cell" in msg
assert "out of notebook" not in msg
# code_abs = [1, 4, 5], n_code = 3 : code[3] est OOR, la cellule
# absolue 3 est du markdown (ancre pensee au layout MAIN).
md_carrier = [_md("voir code[3]"), _code("a"), _md("p"), _md("q"),
_code("b"), _code("c")]
assert "absolute cell 3 is markdown" in scan_anchors(md_carrier)[0]["message"]
# n = 6, n_code = 3 : code[9] est OOR et l'index absolu depasse le carnet.
beyond = [_md("voir code[9]"), _code("a"), _code("b"), _code("c"),
_md("pied"), _md("fin")]
assert "absolute cell 9 is out of notebook" in scan_anchors(beyond)[0]["message"]


# ---------------------------------------------------------------------------
# Class (c): diacritics
Expand Down
Loading