Repository navigation
fix(search): retargeter les renvois App-12 -> App-14b dans Search-17 - #13810
Closed
myia-po-2023 wants to merge 1 commit into
Closed
myia-po-2023 wants to merge 1 commit into
myia-po-2023 wants to merge 1 commit into
Conversation
…ch-17 Le commit 07bf760 a reclassifie App-12-ConnectFour en App-14b/14c sur main sans corriger les deux renvois du notebook Search-17 (cellules 8 et 8.7), laissant 2 navlinks cassees (PASS/FAIL du garde check-navlinks sur toute PR dont le merge tree les traverse). Ce PR retargete les deux liens vers App-14b-ConnectFour.ipynb (algorithme Python), marquage only, aucune cellule code modifiee. Grain: LIGHT/notebook-python — lane myia-po-2023:CoursIA-2 — prev: MED/notebook-python #13606
Collaborator
Author
|
Se ferme au profit de #13808 (ai-01) qui porte le fix du rouge check-navlinks main-side. Note : #13808 ne touche que baseline_nb_navlinks.json (accommodation) ; le lien de Search-17 vers App-12 reste un lien mort dans le notebook (masqué par la baseline, pas réparé). Mon #13810 retargetait le lien vers App-14b (racine). Si tu préfères le fix racine, je peux le refolder dans #13808 ou en réouvrir un dédié. |
Contributor
Contributor
Golden-Set Execution (H.7 P3)✅ 8/8 notebooks passed (certified reproducible)
Pinned lockfile: |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Le commit
07bf76093(« reclass(search): App-12 ConnectFour devient App-14b/14c, companions de App-14 ») a renommé le notebook App-12-ConnectFour surmainsans corriger les deux renvois qui y pointaient depuisSearch-17-Empirical-Algorithm-Selection.ipynb(cellules « ## 8. Deuxième terrain » et « ## 8.7 Renvois »). Il en résulte 2 navlinks cassées, qui font échouer le gardecheck-navlinkssur toute PR dont l'arbre de merge les traverse — y compris le PR de sweep newline #13606 (ma lane), bloqué par cette régression main-side alors que mon diff ne touche pasSearch-17.Ce PR retargete les deux liens vers
App-14b-ConnectFour.ipynb(le notebook Python remplaçant, dans le même répertoireSearch/Applications/Search/). Modif markdown-only : aucune cellule code ni output modifiée.Validation
python scripts/notebook_tools/check_notebook_navlinks.py --check→OK: 0 NEW broken navlink vs baseline(exit 0).python scripts/notebook_tools/validate_pr_notebooks.py origin/main MyIA.AI.Notebooks/Search/Part1-Foundations/Search-17-Empirical-Algorithm-Selection.ipynb→1/1 passed (27 code cells).Impact
Débloque #13606 (que je répare par ailleurs) : sa dernière red restante était ce
check-navlinksmain-side. Après merge de ce fix, l'arbre de merge de #13606 porte les liens retargetés.Grain: LIGHT/notebook-python — lane myia-po-2023:CoursIA-2 — prev: MED/notebook-python #13606