Fix CSRF incompatibility with custom CSRF_HEADER_NAME in sortable updates (refs #434)#435
Open
kirpit wants to merge 1 commit intojrief:masterfrom
Open
Fix CSRF incompatibility with custom CSRF_HEADER_NAME in sortable updates (refs #434)#435kirpit wants to merge 1 commit intojrief:masterfrom
kirpit wants to merge 1 commit intojrief:masterfrom
Conversation
Pass Django's CSRF header setting from admin context to sortable config and use it when sending drag-and-drop update POST requests. Keep backward compatibility by falling back to X-CSRFToken. Add a regression test that verifies: - custom CSRF header is exposed in sortable config - default header is rejected when CSRF_HEADER_NAME is customized - custom header succeeds for adminsortable2_update Refs jrief#434
jrief
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Respect custom CSRF_HEADER_NAME in sortable update requests
Pass Django's CSRF header setting from admin context to sortable config and use it when sending drag-and-drop update POST requests. Keep backward compatibility by falling back to X-CSRFToken.
Add a regression test that verifies:
Refs #434