Make connect_tls_psk_tunnel and connect_tls_psk_tunnel_native generic#99
Merged
Merged
Conversation
Both functions now accept any `S: ReadWrite` instead of hardcoding `Box<dyn ReadWrite>` / `TcpStream`. Callers no longer need to box their streams.
maxslarsson
force-pushed
the
generic-tls-psk-tunnel
branch
from
d62873f to
c862351
Compare
Owner
|
Thanks. I'm curious, what are you using this library for? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
connect_tls_psk_tunnelandconnect_tls_psk_tunnel_nativegeneric over anyS: ReadWriteinstead of requiringBox<dyn ReadWrite>orTcpStreamspecifically.This lets callers pass any stream type directly without boxing. The underlying implementations (
tls_psk_handshakeandtokio_openssl::SslStream::new) were already generic, so this just threads that genericity through to the public API.Changes:
connect_tls_psk_tunnel_native:Box<dyn ReadWrite>->S: ReadWriteconnect_tls_psk_tunnel:tokio::net::TcpStream->S: ReadWriteBox::new()wrapping intunnel_provider.rs