Fix review scoping, TUI markdown, slash args, and patch regressions#56
Open
congjiujiu wants to merge 1 commit into
Open
Fix review scoping, TUI markdown, slash args, and patch regressions#56congjiujiu wants to merge 1 commit into
congjiujiu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved issues
Resolves #51
Resolves #52
Resolves #53
Resolves #54
Details
#51 Scope PR review file tools to repo root
ProjectRootplumbing through engine creation, CLI run/workflow/team paths, TUI session refresh/switching, and spawned subagents.read,glob,grep, andlsso default and relative paths resolve under the detected project root./Users,/, and common macOS protected folders..git,node_modules,vendor,.cache,Library,Desktop,Documents,Downloads,Music,Pictures,Movies,Photos, andLibrary/Mobile Documents.grepexclusions so nested protected directories likesrc/Documentsare excluded too./review <GitHub PR URL>handling that prepares a dedicated checkout and re-scopes file tools to that checkout root before review.#52 Render markdown in assistant messages
I'm **altcode**while preserving literal markdown inside fenced code blocks.#53 altcode review on altcode findings
patchcommand context andpatch --batchso system patch cannot hang indefinitely.patch.#54 Preserve original prompt after evaluate finishes
/evaluate <prompt>keep user arguments even whenSKILL.mddoes not include$ARGUMENTS.User request:for skill commands without explicit argument placeholders.Tests
make buildGOFLAGS=-mod=mod go build ./...GOFLAGS=-mod=mod go vet ./...GOFLAGS=-mod=mod go test ./... -race -count=1 -timeout=180s