Open
Conversation
basel1322
added
the
safe to test
github-actions
bot
removed
the
safe to test
basel1322
added
the
safe to test
github-actions
bot
removed
the
safe to test
attiasas
reviewed
Feb 24, 2026
Collaborator
attiasas
left a comment
attiasas
left a comment
There was a problem hiding this comment.
Nice! take a look at my comments. in addition:
- TestGradleCurationAuditMode seems redundent now with the new tests. consider removing it (but still adding only assert on isCurationCmd where possiable
- Add a test case with isCurationCmd: true and depsRepo: "" to verify no prefix is applied and the script generates cleanly without a repository block.
- We need to wait for the gradle-dep-tree version release when the dependent PR is merged
basel1322
added
the
safe to test
github-actions
bot
removed
the
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
Fixed an issue when running jf ca while happening plugins in settings file, we get blocked while building the deptree.
I have added /api/curation/audit so it wont get blocked while building the tree