Open
Conversation
Contributor
orto17
commented
Feb 18, 2026
orto17
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
- Update documentation about new features / new supported technologies
orto17
added
new feature
github-actions
bot
removed
the
safe to test
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
attiasas
reviewed
Feb 19, 2026
Contributor
attiasas
left a comment
attiasas
left a comment
There was a problem hiding this comment.
Nice!, take a look at my comments.
- consider fixing linter issues
- consider adding more test cases to expand coverage
eranturgeman
added
improvement
# Conflicts: # packageupdaters/commonpackageupdater_test.go # scanrepository/scanrepository.go
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
Contributor
| } | ||
| // Working buffer for the update chain. Each update returns a new slice (e.g. regexp.ReplaceAll), | ||
| // so we never mutate the original content. No backup or revert—we only write to the file on success. | ||
| currentContent := content |
Collaborator
There was a problem hiding this comment.
you can simply work on 'content' as 'currentContent := content' simply creates a pointer to 'content', but if you still want to have it for clearer naming you can leave it
eranturgeman
approved these changes
Feb 24, 2026
Collaborator
eranturgeman
left a comment
eranturgeman
left a comment
There was a problem hiding this comment.
Looks good! please see failing test in Package Updaters Tests (TestUpdateDependency/maven-direct-dep)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.