[xray] Update values to fix odd bug with linkerd#1998
Open
efrenaguilar95 wants to merge 6 commits intojfrog:masterfrom
Open
[xray] Update values to fix odd bug with linkerd#1998efrenaguilar95 wants to merge 6 commits intojfrog:masterfrom
efrenaguilar95 wants to merge 6 commits intojfrog:masterfrom
Conversation
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[artifactory])What this PR does / why we need it:
This PR fixes an odd issue found when working with a linkerd integration.
More information can be found in the issue itself. tl;dr The issue is caused by the
observabilitycontainer probes missing the leading/in the values file. This is a small PR to fix this, has been tested and confirmed. Should have no real affect to the xray service itself, for the scope of this repo, its pretty much a typo fix. (If even that)