Skip to content

fix ctrl-i/ctrl-h/ctrl-b/ctrl-f#5149

Closed
phanen wants to merge 2 commits intojesseduffield:masterfrom
phanen:fix-keys
Closed

fix ctrl-i/ctrl-h/ctrl-b/ctrl-f#5149
phanen wants to merge 2 commits intojesseduffield:masterfrom
phanen:fix-keys

Conversation

@phanen
Copy link
Copy Markdown
Contributor

@phanen phanen commented Dec 30, 2025 •
edited
Loading

  • fix: ctrl-i don't work after fec7e9c
  • fix: missing readline keybind in commit editor

PR Description

After updating from source I notice many keybind broken.
Because a recent bump of gocui/tcell.

gocui pr: jesseduffield/gocui#92

Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@phanen
fix: ctrl-i don't work after fec7e9c
39200b5 
tcell now can distinguish them
phanen/tcell@74fd487

I always use c-i as tab key, to resume the behavior, this commit allow:
togglePanel: <c-i>
@phanen
fix: missing readline keybind in commit editor
efbc4ed 
ctrl-b/ctrl-f commit here: 6422b39
Didn't port to gocui, disappear in
bb816d7

Add ctrl-h because not it's no longer recgnoized as backspace since
(tcell distinguish them).
@phanen phanen marked this pull request as draft December 30, 2025 12:48
@phanen phanen mentioned this pull request Dec 30, 2025
Closed
stefanhaller
stefanhaller reviewed Jan 3, 2026
View reviewed changes
Comment thread pkg/config/keynames.go
Comment on lines +55 to +60
gocui.KeyCtrlH: "<c-h>",
gocui.KeyCtrlI: "<c-i>",
gocui.KeyCtrlJ: "<c-j>",
gocui.KeyCtrlK: "<c-k>",
gocui.KeyCtrlL: "<c-l>",
gocui.KeyCtrlM: "<c-m>",
Copy link
Copy Markdown
Collaborator

@stefanhaller stefanhaller Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to add any of these to the list just yet. The upgrade of tcell allows us to have many more available keybindings (e.g. <s-c-a-pgup>), but we need some changes to our keybinding infrastructure to handle these. And they will only be available if the terminal supports the new key event protocol, so we need to find a way to warn the user if theirs doesn't. I'm working on this (slowly, might take a few more weeks), and I want to add these missing keybindings then.

Copy link
Copy Markdown
Contributor Author

@phanen phanen Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Now for me the only missing part is to make can work as tab in lazygit (togglePanel). Which I think you will resolve later.

Comment thread vendor/github.com/jesseduffield/gocui/edit.go
Comment thread vendor/github.com/jesseduffield/gocui/edit.go
@stefanhaller stefanhaller mentioned this pull request Jan 6, 2026
Closed
@phanen
Copy link
Copy Markdown
Contributor Author

phanen commented May 1, 2026

Close, as this seems already supported on master. Many thanks!

@phanen phanen closed this May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefanhaller stefanhaller stefanhaller left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phanen @stefanhaller