Fix nonnull_unchecked_on_box_ptr lint - #243
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is localized and resolves the lint without altering the cache’s core logic or invariants.
Pull request overview
This PR updates LruCache’s node allocation path to fix the Clippy nonnull_unchecked_on_box_ptr lint by removing an unsafe NonNull::new_unchecked(...) construction in favor of a safe NonNull creation approach.
Changes:
- Replaces
NonNull::new_unchecked(Box::into_raw(Box::new(...)))with a safeNonNullconstruction for newly allocatedLruEntrynodes. - Removes the now-unneeded safety comment tied to the prior
unsafeblock.
File summaries
| File | Description |
|---|---|
| src/lib.rs | Reworks node allocation to avoid NonNull::new_unchecked and satisfy the Clippy lint. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.