Skip to content

fix(access-requests): replace leaked <missing> placeholder with actionable field error#565

Open
juliahooper wants to merge 1 commit into
jentic:mainfrom
juliahooper:fix/access-request-missing-field-error
Open

fix(access-requests): replace leaked <missing> placeholder with actionable field error#565
juliahooper wants to merge 1 commit into
jentic:mainfrom
juliahooper:fix/access-request-missing-field-error

Conversation

@juliahooper

Copy link
Copy Markdown

Summary

  • Introduces RequiredFieldMissingError for access request items missing required fields (to_id, resource_id)
  • Replaces three sites that raised domain exceptions with "<missing>" as a placeholder ID, leaking it into Problem Details responses
  • Agents now get clear messages like "Required field 'to_id' is missing on the access request item; credential:bind requires a target toolkit"

Test plan

  • Updated 3 existing unit tests to assert new exception type
  • Verified no "<missing>" remains in error paths (grep clean)
  • make test-fast passes (1929 tests, 78.64% coverage)
  • ruff check + mypy clean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant