Migrate from Commons Lang to native Java Platform functionality - #32
Open
timja wants to merge 1 commit into
Open
Migrate from Commons Lang to native Java Platform functionality#32timja wants to merge 1 commit into
timja wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to use a third-party library when this functionality is available in the Java Platform.
Part of the effort to remove Commons Lang 2 from Jenkins core — jenkinsci/jenkins#16404,
jenkinsci/jenkins#26105. Commons Lang 2 is EOL and carries an unfixed advisory
(GHSA-j288-q9x7-2f5v).
What's changed
StringUtils.isEmpty/isNotEmpty→Util.fixEmpty(x) == null/!= null.StringUtils.join(messages, "\n\n")→String.join("\n\n", messages)in both log parsers.LogNodeUtils.getMessagesonly inserts a message after checkingmessage != null && !message.isEmpty(),so the list never holds nulls and
String.joincannot NPE here.No new dependency is added.
commons-lang3-apiis not an option here: it requires core 2.479.3 andthis plugin's baseline is 2.361.4.
Note on testing: this plugin does not build on JDK 21 —
masterfails the same way, withIllegalArgumentException: Unsupported class file major version 65out of the Groovy that parentPOM 4.65 pulls in. I verified on JDK 17 instead. That is pre-existing and untouched by this PR.
Testing done
mvn -B -ntp clean verifypasses locally on Java 17 / macOS.The
ban-commons-lang-2enforcer rule was left disabled because it needs parent POM6.2116.v7501b_67dc517or newer; bumping the parent from4.65pulls in the Jakarta EE 9migration, which is out of scope for this change.
Submitter checklist
🤖 This pull request was generated with AI assistance (Claude Code) as part of a bulk migration
across Jenkins plugins. If anything here looks wrong, please comment on this PR or contact
@parameter.