Repository navigation
Conversation
Author
|
The CI failure is caused by jdk17, being still in "main" Jenkinsfile, where PR is already jdk21+ bound due tu natural parent/baseline bump. Maybe the Should go in first. |
as per jenkins-infra/repository-permissions-updater#5172 (comment) evaluated and set @SuppressWarnings("lgtm[jenkins/no-permission-check]") at same adjsuted usemap attribute retrival test
judovana
force-pushed
the
tapBaseUpdate
branch
from
October 12, 2026 15:03
a34272e to
3bfc43b
Compare
Closed
4 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! This PR is updating jenkins plugin parent and baseline jenkins to currently recommended versions (so ultimately overridwes eg #46) . That includes (mandatory) bump to junit5 and (optional) fix of automated jenkins security audit.
I believe the three commits should go as three commits. Unluckily the first (bumped parent/jenkins) can not be properly posted without second (junit5). The third (
@post) may be separate PR. The only logical change should be the change inrenderTooltipsWithFailedBuilds, where HtmlUnit is unable to correctly obtain map from@postmethod. Manual testing showed it works fine.TLDR:
hi again! Since you stopped to review, and possibly integrate most (all? [1][2][3][4][5]) feature PRs, and moved to integrate only CVE and necessary fixes, I had tried to co-maintain [6]. That was (correctly!) closed, and you mentioned that I should do something useful, instead of suspicious feature PRs. The issues I had access to, did not seem to be critical enough, so I gave up, and continued living in fork [7].
Unluckily living in private fork is extremely clumsy, and in addition, from time to time I work on projects which have only public jenkins repos available. In that moment when [5] went missing again, and I always had a feeling I'm back in 7th century. The [5] (or something similar is critical to process bigger taps, and I have to deal with taps full of thousands of tests. That also mean that [5] is battle tested, and is not suffering (noticeable) performance regression.
As I'm again bound to project with public repos only, I tired to go with fork out as [8]. It s fate is not yet decided, and I hope on long run you will acept this, [5], maybe more (like eg [7]), and in ideal word I will be allowed to help you to co-maintan it, as it seems my life is cycrcling about TAP results.. Unbelievable :). I think I would be slightly more vigilant to various mandatory, but not critical updates, but would be probably more open to 3rd party feature requests.
Anyway the outcome of [8] were:
Which are both (the first have mandatory consequence of junit5 ) fixed in this PR.
I hope you will find this useful.
[1] #5 2014
[2] #11 2016
[3] #18 2017
[4] #26 2019
[5] #38 2024 (+#29)
[6] jenkins-infra/repository-permissions-updater#3552
[7] https://github.com/judovana/tap-interactive-plugin
[8] jenkins-infra/repository-permissions-updater#5172
Testing done
Submitter checklist