Fix various warnings #2053
Merged
Fix various warnings #2053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add __del__ method to Protocol that raises ResourceWarning if not explicitly closed - Fix test_client tests to properly close Protocol objects returned by _connect() - Fix TestSSHVendor.Subprocess mock methods to accept proper arguments
- Add __del__ methods to Pack and PackData that raise ResourceWarning if not explicitly closed - Fix test_bundle to properly close PackData objects using addCleanup - Set _file/_data/_idx to None after closing to prevent double-close
Add proper cleanup for MemoryRepo instances in test files to prevent resource leaks.
jelmer
force-pushed
the
fix-various-warnings
branch
from
fdf1e45 to
ef3934e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.