Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0181seTYh8Bo6yc19Ba5p5bo
This was referenced Oct 17, 2026
Open
selmant
added a commit
to selmant/better-trakt
that referenced
this pull request
Oct 23, 2026
jellyfin#320 Original author: @zotabee. Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codec mapping only looks at the codec name, so TrueHD Atmos is sent as
dolby_truehd, DD+ Atmos asdolby_digital_plus, and DTS-HD MA, DTS-HD HRA and DTS:X all as plaindts. Trakt has its own value for each of them (API docs).The mapping now also reads the stream's
AudioSpatialFormat(DolbyAtmos / DTSX), which Jellyfin takes from FFmpeg's profile name (MediaStream.cs, profiles.c), and the profile itself for DTS-HD MA and HRA. DTS:X is checked first, because its profile name also contains "DTS-HD MA". With "Send media technical info to Trakt" on, the next export updates the affected items.Tested on my Jellyfin 12.1 server since 2026-10-18. The first export sent
dolby_digital_plus_atmosfor 664 items,dts_mafor 63 (one of them, Weeds S06E03, only together with #323, because its first audio track is a commentary) anddolby_atmosfor 6, and comparing my Trakt data exports from before and after, trakt.tv has exactly those values now. Two of them, plus test films I added (my library has no DTS:X or DTS-HD HRA, and its TrueHD Atmos items are episodes); for the test films, the master column comes from master's code:dolby_digital_plusdolby_digital_plus_atmosdtsdts_madtsdts_xdtsdts_hrdolby_truehddolby_atmosTrakt's new API docs no longer list these metadata fields; I asked about it in trakt/trakt-api#1012.
Builds with no warnings on its own and merges cleanly with #321, #322, #323, #329 and #342, which change the same file.