fix: avoid crash when jekyll-archives.layouts is not a hash#186
Open
wwenrr wants to merge 1 commit into
Open
Conversation
Handle malformed jekyll-archives.layouts config defensively by falling back to the default layout key instead of calling dig on a non-Hash value. Add regression coverage for malformed layouts config to ensure archive generation does not crash. Fixes jekyll#181
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a configuration edge-case that can crash archive generation when
jekyll-archives.layoutsis set to a non-Hash value (for example, a string due to typo or misconfiguration).Instead of calling
digunconditionally, layout/permalink lookups are now guarded to only index when the nested config is actually a Hash, with graceful fallback to the default layout.Changes
Jekyll::Archives::Archive#layoutto safely handle malformedlayoutsconfig.Jekyll::Archives::Archive#templatesimilarly for defensive consistency.layoutsno longer raises and archive pages are still generated with fallback layout.Manual verification
Ran tests in Docker (Ruby 3.3):
Result:
22 runs, 54 assertions, 0 failures, 0 errors, 0 skipsFixes #181