fix: eliminate variable shadowing in get_embedding and add list key support (Fixes #37) - #39
Open
rtmalikian wants to merge 1 commit into
Open
fix: eliminate variable shadowing in get_embedding and add list key support (Fixes #37)#39rtmalikian wants to merge 1 commit into
rtmalikian wants to merge 1 commit into
Conversation
…upport Fixes jdagdelen#37 - Rename loop variable from to and use accumulator to avoid shadowing the function parameter when traversing nested keys - Add support for list keys (e.g., key=['name', 'city']) for selective field concatenation - Add missing newline stripping in the key=None path (was only applied in the str-key path, causing inconsistency) - Add comprehensive tests for all key extraction paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37
Problem
get_embedding()has a variable shadowing bug: the loopfor key in key_chainoverwrites the function parameterkey. While Python's loop semantics prevent a crash in most cases, this makes the code fragile and hard to maintain. Additionally, thekey=Nonepath was missing newline stripping that thekey=strpath had, causing inconsistent text cleaning.Solution
Three changes to
hyperdb/hyperdb.py:keytokand use avalueaccumulator to traverse nested keys, keeping the originalkeyparameter intactkeyis a list (e.g.,key=["name", "city"]), extract those specific fields for concatenation — addresses the issue's concern about key type handlingreplace("\n", " ")in thekey=Nonepath, matching the behavior of thekey=strpathVerification
Contact
About the Author: Raphael Malikian — Clinical AI Solutions Architect. I specialise in building and fixing AI/ML systems for healthcare, including vector databases, RAG pipelines, and clinical NLP. If you need help with your project or think I can add value to your organisation, feel free to reach out — I'd love to connect.
📧 rtmalikian@gmail.com
🔗 GitHub: https://github.com/rtmalikian
🔗 LinkedIn: http://www.linkedin.com/in/raphael-t-malikian-mbbs-bsc-hons-71075436a
Disclosure: This code was developed with assistance from mimo-v2.5-pro (Xiaomi) via Hermes Agent (Nous Research). All changes were reviewed, tested against the actual codebase, and verified for correctness.